michaelandrepearce edited a comment on issue #2533: ARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer timeout URL: https://github.com/apache/activemq-artemis/pull/2533#issuecomment-463614378 To me it seems we shouldnt have change critical analyslzer at all. Its done its job. Its detected on a critical path the is something blocking and it shouldnt be. The real fix is to fix the block, not remove the safety check. It was added for this exact purpose!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
