michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 
Enhanced Message Groups Support
URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r258247750
 
 

 ##########
 File path: 
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java
 ##########
 @@ -454,7 +454,16 @@ public boolean contains(final char c) {
     * @return the concatenated SimpleString
     */
    public SimpleString concat(final String toAdd) {
-      return concat(new SimpleString(toAdd));
+      int len = toAdd.length();
 
 Review comment:
   Its existing code its already covered, 
   
   also i checked to be sure and it shows as being tested when using code 
coverage.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to