michaelandrepearce commented on a change in pull request #2549: ARTEMIS-2251
Large messages might not be deleted when server crashed
URL: https://github.com/apache/activemq-artemis/pull/2549#discussion_r258310314
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
##########
@@ -432,7 +432,7 @@ public void freeDirectBuffer(ByteBuffer buffer) {
journalFF.releaseBuffer(buffer);
}
- public long storePendingLargeMessage(final long messageID, long recordID)
throws Exception {
Review comment:
There is diff between a memory block and an waiting on disk io.
Can this not be async with a callback with a response later?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
