orpiske commented on issue #2564: ARTEMIS-2183 Useless statement in public synchronized List URL: https://github.com/apache/activemq-artemis/pull/2564#issuecomment-466775546 > Take a look at the history for it ans maybe it has been changed from something that was correct before! It seems that it was already this way when this code was introduced, [around October 2014](https://github.com/apache/activemq-artemis/commit/177e6820b541e0a71b952eebf503a4d2235910c5#diff-321554fd18f6c7a3a382a7d50ce7a1abR191). Maybe we would need to go even farther ahead in the past to figure out. Looking at the original HornetQ code, it seems that it used to [return the refsToAck](https://github.com/hornetq/hornetq/blob/HornetQ_2_2_25_Final/src/main/org/hornetq/core/server/impl/QueueImpl.java#L2712).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
