orpiske commented on a change in pull request #2564: ARTEMIS-2183 Useless
statement in public synchronized List
URL: https://github.com/apache/activemq-artemis/pull/2564#discussion_r259943352
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RefsOperation.java
##########
@@ -190,9 +190,7 @@ private void decrementRefCount(MessageReference refmsg) {
@Override
public synchronized List<MessageReference> getRelatedMessageReferences() {
- List<MessageReference> listRet = new LinkedList<>();
Review comment:
Yeah, the original commit was just replacing the addAll with a return of an
empty list. I modified it to return refsAcks.
Given that there can be unintended consequences here, I am closing the PR
and letting those of you with more experience on the code base to decide what
may be the more appropriate solution in this case.
Nonetheless, I agree with @michaelandrepearce, that there is something
strange with the original code that the PR intended to fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
