michaelandrepearce commented on a change in pull request #2568: ARTEMIS-2262:
Correlate management response messages with the request
URL: https://github.com/apache/activemq-artemis/pull/2568#discussion_r260477757
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/management/impl/ManagementServiceImpl.java
##########
@@ -390,6 +393,11 @@ public ICoreMessage handleMessage(Message message) throws
Exception {
reply.setType(Message.TEXT_TYPE);
reply.setReplyTo(message.getReplyTo());
+ String correlationId = getCorrelationIdentity(message);
+ if (correlationId != null) {
+ MessageUtil.setJMSCorrelationID(reply, correlationId);
Review comment:
e.g. what would occur for other protocols that in future we may want to
support management service, that may not match/able to wrap to JMS.
It would be better to introduce correlationId get and set methods at message
api level, e.g. in AMQP it would set directly into properties, and for CORE
could make it map to a _AMQ property. etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
