OK, I got your point. Just as reminder, the original Jira is AMQ-7301. The users are complaining to have a full stack trace in the log (useless). That’s why I changed.
Let me reopen the Jira and move forward with a satisfying solution for you. Thanks, Regards JB > Le 9 mars 2020 à 15:20, Christopher Shannon <[email protected]> > a écrit : > > For number 2 you are logging and then swallowing the error and not > propagating it up. If you want to log it there you at least need to throw > the exception back up like every other protocol so it's handled > consistently. As I said it makes no sense to treat that differently than > any other protocol. The initializedStreams() method is called be all > NIOSSLTransport protocols and the others throw the exception. > > So number 2 is still a -1 for me the way it currently it is without > throwing the exception. > > On Mon, Mar 9, 2020 at 9:38 AM jbonofre <[email protected]> wrote: > >> Hi Chris, >> >> Thanks for your vote and feedback. >> >> About 1, you are right I gonna test to avoid NPE. >> >> About 2, I fixed a jira from users. And actually the exception is not fully >> swallowed: it?s logged single line. I didn?t want to change globally but I >> can if you think it makes more sense. However I had a long discussion with >> one user in particular who reported the jira (it?s a very large activemq >> user in Europe) and he has good arguments. So I fixed accordingly. >> >> I will cancel vote to fix 1 but 2 looks good to me. >> >> Regards >> JB >> >> >> >> -- >> Sent from: >> http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html >>
