Are you able to send a PR? On Wed, Apr 8, 2020 at 2:24 AM Michael Pearce <[email protected]> wrote:
> Another thing to point out as raised in last release building on windows > was broken i would like to see that regression fixed else i would be > inclined to -1 the release. > > I missed the opportunity last release to -1 as was late to vote. > > On Wed, 8 Apr 2020, 04:08 Clebert Suconic, <[email protected]> > wrote: > > > So, TL;DR: I had been keeping an eye on the testsuite, and we are > > clear at this point. You spotted an intermittent failure that would > > fail 1 in 10 and I just fixed it. > > > > So, we are fine. if you see any other issues please let me know here. > > > > On Tue, Apr 7, 2020 at 9:13 PM Clebert Suconic > > <[email protected]> wrote: > > > > > > The issues reported on ARTEMIS-2659 I fixed last week, as I had an > > > encoding issue for Large Messages that I fixed. > > > > > > The one thing I'm not sure what's happening is on > > > testAcceptWithoutSettling that fails in a loop. But the test has been > > > clear for the past week after I fixed the encoding. > > > > > > > > > I have recently fixed an issue with threading in AMQP that was leading > > > to scalability issues. Perhaps some asynchronous factor caused some > > > issue to the test. I will investigate. > > > > > > > > > > > > On Tue, Apr 7, 2020 at 8:29 PM Timothy Bish <[email protected]> > wrote: > > > > > > > > I'd recommend looking into the failures documented in this issue as > > they > > > > seem to indicate regressions in the AMQP protocol handler stack as > > > > compared to the previous release which doesn't seem to reproduce > these > > > > from testing myself and Robbie have done. > > > > > > > > https://issues.apache.org/jira/browse/ARTEMIS-2659 > > > > > > > > I'd be inclined to -1 any release that still expresses those > failures. > > > > > > > > On 4/7/20 7:22 PM, Clebert Suconic wrote: > > > > > I asked Justin, and he will try for it... if it's just a day or two > > > > > delay we should probably wait. if it delays any further that's > what I > > > > > meant for another release in about a month. > > > > > > > > > > On Tue, Apr 7, 2020 at 5:24 PM Michael Pearce < > > [email protected]> wrote: > > > > >> Is it worth getting the queue config refactor in before this > > release? That > > > > >> Justin has worked on. That way we can have a release with the > > refactor and > > > > >> then the test cases could be refactored for the following release. > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> On Tue, 7 Apr 2020, 17:57 Clebert Suconic, < > > [email protected]> > > > > >> wrote: > > > > >> > > > > >>> I am planning a release on April 13th. > > > > >>> > > > > >>> and at least for the short term I want to keep a more frequent > > release > > > > >>> schedule, with another one in the first week of May. which I will > > send > > > > >>> another heads up by the end of this month. > > > > >>> > > > > >>> > > > > >>> There are a lot of good enhancements to be released now.. good > > fixes. > > > > >>> The testsuite is quite stable on my long running internal jenkins > > > > >>> instance (nothing fancy.. just running the whole testsuite > daily). > > > > >>> > > > > >>> > > > > >>> so, If we could merge / review the PRs we have now.. and if there > > is > > > > >>> anyone wanting to hold a bit. .this is channel to discuss about > it. > > > > >>> > > > > >>> > > > > >>> Thanks > > > > >>> > > > > >>> -- > > > > >>> Clebert Suconic > > > > >>> > > > > > > > > > > > > > > > > > > -- > > > > Tim Bish > > > > > > > > > > > > > -- > > > Clebert Suconic > > > > > > > > -- > > Clebert Suconic > > > -- Clebert Suconic
