Just a heads up, I have everything ready, tagged and staged. Feel free to merge on master already:
https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis/2.12.0 I will send the VOTE thread tomorrow morning after I do some final verification. On Thu, Apr 16, 2020 at 10:39 AM Clebert Suconic <[email protected]> wrote: > > They take 2 hours and 20 minutes, and they have intermittent failures that we > manage. (Some test issues). > > we tried to having them running on apache boxes, but I don't think the boxes > are big enough.. some of these tests are using a lot of disk IO.. so you need > a decent size box.. preferably a metal box, or a big cloud instance. > > > it's not feasible to run them on every PR. I think it also goes beyond the > public CI timeout limit. you would probably have to buy support. > > > so, we keep them running on a server I own at the company I work for, and I > run it on my personal home desktop from time to time. When issue diverge I > raise back to the PRs or fix it myself. > > > But these cancellations I had were not about the testsuite.. they were about > issues found on AMQP/LargeMessage. and since we merged big PRs I wanted to > make sure I run my daily tests before the release.. and I was having > issues... at some point this was enough time for Robbie to find more issues.. > when I joked about it. > > > > > > > On Thu, Apr 16, 2020 at 8:58 AM Krzysztof <[email protected]> wrote: >> >> Forgive me my ignorance but why running these tests isn't a part of CI. >> Shouldn't the master be green and ready for release at any point in time? >> >> Chris >> >> On Wed, Apr 15, 2020 at 11:49 PM Clebert Suconic <[email protected]> >> wrote: >> >> > Ok... >> > >> > >> > merged the dependency, and sent a PR on large message: >> > https://issues.apache.org/jira/browse/ARTEMIS-2712 >> > >> > you shot at a bug, and found two, one for amqp abort, one for >> > connection abort / drop. >> > >> > >> > It's fixed.. I'm running tests.. and if it's all good I will merge it >> > myself. >> > >> > >> > I will cut it tomorrow if it's all good then... >> > >> > >> > So, just please stop finding issues for a day? (LOL.. just a joke of >> > course) >> > >> > On Wed, Apr 15, 2020 at 12:51 PM Justin Bertram <[email protected]> >> > wrote: >> > > >> > > This dependency update [1] should probably go in before the release. >> > There >> > > is a transitive dependency on artemis-commons, but it's best to make it >> > > explicit. >> > > >> > > >> > > Justin >> > > >> > > [1] https://github.com/apache/activemq-artemis/pull/3085 >> > > >> > > >> > > On Wed, Apr 15, 2020 at 7:13 AM Robbie Gemmell <[email protected] >> > > >> > > wrote: >> > > >> > > > I've just raised https://issues.apache.org/jira/browse/ARTEMIS-2712, >> > > > I'd say it needs investigated/addressed prior to release given the >> > > > potential result. >> > > > >> > > > The prior https://issues.apache.org/jira/browse/ARTEMIS-2706 (and >> > > > now-subtask 2707) is now much better, and releasable. There is still >> > > > room for improvement for peers setting a lower frame size than the >> > > > broker will allow sending (many dont, but some do). >> > > > >> > > > Robbie >> > > > >> > > > On Wed, 15 Apr 2020 at 03:28, Clebert Suconic < >> > [email protected]> >> > > > wrote: >> > > > > >> > > > > Just FYI: I'm struggling with the testsuite. >> > > > > >> > > > > At this point it seems environmental. I want to get a full testsuite >> > > > > run before the release. >> > > > > >> > > > > Rather than keep postponing, lets just say I will cut the release as >> > > > > soon as I get a pass. >> > > > > >> > > > > Meanwhile if you have anything major you want to merge / commit, >> > > > > please hold from doing so.. and if you really want it.. talk to mere >> > > > > here, or any other way you get contact me. >> > > > > >> > > > > On Tue, Apr 14, 2020 at 3:26 PM Clebert Suconic >> > > > > <[email protected]> wrote: >> > > > > > >> > > > > > I have had a few last minutes changes as I have been running >> > tests... >> > > > > > merges.. etc... >> > > > > > >> > > > > > >> > > > > > @all please refrain from merging/committing anything today into >> > master >> > > > > > between today and tomorrow. I should start the release process >> > > > > > tomorrow morning. >> > > > > > >> > > > > > (I'm giving it an extra day after the last changes in case someone >> > has >> > > > > > anything to say between today and tomorrow). >> > > > > > >> > > > > > On Mon, Apr 13, 2020 at 2:39 PM Clebert Suconic >> > > > > > <[email protected]> wrote: >> > > > > > > >> > > > > > > As long as we are not hitting a regression. We should be fine. >> > > > > > > >> > > > > > > On Mon, Apr 13, 2020 at 11:50 AM Robbie Gemmell < >> > > > [email protected]> wrote: >> > > > > > >> >> > > > > > >> I still see some sporadic failures in the AMQP tests, I raised >> > a PR >> > > > to >> > > > > > >> fix a couple of issues: >> > > > > > >> https://github.com/apache/activemq-artemis/pull/3077 >> > > > > > >> >> > > > > > >> I've also raised >> > https://issues.apache.org/jira/browse/ARTEMIS-2706 >> > > > > > >> and https://issues.apache.org/jira/browse/ARTEMIS-2707 as >> > > > unresolved >> > > > > > >> offshoots of https://issues.apache.org/jira/browse/ARTEMIS-2659 >> > , >> > > > > > >> either from the original report or just noticed while reporting >> > > > now. I >> > > > > > >> expect these have likely been introduced by changes since >> > 2.11.0 and >> > > > > > >> if so it would be nice if they got addressed before release. >> > > > > > >> >> > > > > > >> On Thu, 9 Apr 2020 at 21:34, Timothy Bish <[email protected]> >> > > > wrote: >> > > > > > >> > >> > > > > > >> > On 4/9/20 4:25 PM, Clebert Suconic wrote: >> > > > > > >> > > I just did >> > > > > > >> > > mvn install -Prelease >> > > > > > >> > > >> > > > > > >> > > and it completed fine, without any issues. Even running the >> > > > basic tests. >> > > > > > >> > > >> > > > > > >> > > >> > > > > > >> > > if you know anything wrong, please let me know before >> > monday? >> > > > as I >> > > > > > >> > > tried here and everything seems ok. I think Domenico also >> > did >> > > > build on >> > > > > > >> > > his environment and so far everything is good. >> > > > > > >> > >> > > > > > >> > I've run through the AMQP tests quite a few times and nothing >> > > > failed on >> > > > > > >> > either of my machines. >> > > > > > >> > >> > > > > > >> > >> > > > > > >> > > >> > > > > > >> > > It could be something environmental in your system. I just >> > > > tried on a >> > > > > > >> > > brand new Windows 10 machine I have at home, and everything >> > > > seems ok. >> > > > > > >> > > >> > > > > > >> > > On Wed, Apr 8, 2020 at 1:37 PM Clebert Suconic >> > > > > > >> > > <[email protected]> wrote: >> > > > > > >> > >> @Michael: Is the problem running the testsuite on windows? >> > > > > > >> > >> >> > > > > > >> > >> On Wed, Apr 8, 2020 at 12:28 PM brusdev < >> > [email protected]> >> > > > wrote: >> > > > > > >> > >>> Hi Micheal, >> > > > > > >> > >>> >> > > > > > >> > >>> I have downloaded java-1.8.0-openjdk-1.8.0.212-3 and now >> > my >> > > > environment is >> > > > > > >> > >>> like yours: >> > > > > > >> > >>> Apache Maven 3.5.4 >> > (1edded0938998edf8bf061f1ceb3cfdeccf443fe; >> > > > > > >> > >>> 2018-06-17T20:33:14+02:00) >> > > > > > >> > >>> Maven home: C:\Program Files\apache-maven-3.5.4\bin\.. >> > > > > > >> > >>> Java version: 1.8.0_212-3-redhat, vendor: Oracle >> > Corporation, >> > > > runtime: >> > > > > > >> > >>> c:\Program Files\RedHat\java-1.8.0-openjdk-1.8.0.212-3\jre >> > > > > > >> > >>> Default locale: en_US, platform encoding: Cp1252 >> > > > > > >> > >>> OS name: "windows 10", version: "10.0", arch: "amd64", >> > > > family: "windows" >> > > > > > >> > >>> >> > > > > > >> > >>> >> > > > > > >> > >>> I have successfully built on the root path >> > `activemq-artemis` >> > > > using `mvn >> > > > > > >> > >>> -Pdev clean install -DskipTests=true` after that I have >> > > > successfully built >> > > > > > >> > >>> on the path >> > > > `activemq-artemis\artemis-protocols\artemis-mqtt-protocol` using >> > > > > > >> > >>> `mvn install`. >> > > > > > >> > >>> >> > > > > > >> > >>> Analyzing your log I found a >> > > > `java.lang.ClassNotFoundException: >> > > > > > >> > >>> EmbeddedJMSResource`. >> > > > > > >> > >>> >> > > > > > >> > >>> It looks strange to me. I think you could have a dirty >> > maven >> > > > cache. >> > > > > > >> > >>> I used a vanilla Windows 10 and I could get any building >> > > > errors. >> > > > > > >> > >>> I can share my machine if you need to do some tests. >> > > > > > >> > >>> >> > > > > > >> > >>> [INFO] Scanning for projects... >> > > > > > >> > >>> [INFO] >> > > > > > >> > >>> [INFO] -------------< >> > > > org.apache.activemq:artemis-mqtt-protocol >> > > > > > >> > >>>> -------------- >> > > > > > >> > >>> [INFO] Building ActiveMQ Artemis MQTT Protocol >> > 2.12.0-SNAPSHOT >> > > > > > >> > >>> [INFO] -------------------------------[ bundle >> > > > > > >> > >>> ]------------------------------- >> > > > > > >> > >>> [INFO] >> > > > > > >> > >>> [INFO] --- maven-enforcer-plugin:1.4:enforce >> > (enforce-maven) @ >> > > > > > >> > >>> artemis-mqtt-protocol --- >> > > > > > >> > >>> [INFO] >> > > > > > >> > >>> [INFO] --- maven-enforcer-plugin:1.4:enforce >> > (enforce-java) @ >> > > > > > >> > >>> artemis-mqtt-protocol --- >> > > > > > >> > >>> [INFO] >> > > > > > >> > >>> [INFO] --- maven-dependency-plugin:3.1.1:unpack (copy) @ >> > > > > > >> > >>> artemis-mqtt-protocol --- >> > > > > > >> > >>> [INFO] Configured Artifact: >> > > > > > >> > >>> org.apache.activemq:activemq-artemis-native:1.0.1:jar >> > > > > > >> > >>> [INFO] activemq-artemis-native-1.0.1.jar already unpacked. >> > > > > > >> > >>> [INFO] >> > > > > > >> > >>> [INFO] --- maven-remote-resources-plugin:1.5:process >> > > > > > >> > >>> (process-resource-bundles) @ artemis-mqtt-protocol --- >> > > > > > >> > >>> [INFO] >> > > > > > >> > >>> [INFO] --- maven-resources-plugin:2.6:resources >> > > > (default-resources) @ >> > > > > > >> > >>> artemis-mqtt-protocol --- >> > > > > > >> > >>> [INFO] Using 'UTF-8' encoding to copy filtered resources. >> > > > > > >> > >>> [INFO] Copying 1 resource >> > > > > > >> > >>> [INFO] Copying 3 resources >> > > > > > >> > >>> [INFO] >> > > > > > >> > >>> [INFO] --- maven-compiler-plugin:3.1:compile >> > > > (default-compile) @ >> > > > > > >> > >>> artemis-mqtt-protocol --- >> > > > > > >> > >>> [INFO] Nothing to compile - all classes are up to date >> > > > > > >> > >>> [INFO] >> > > > > > >> > >>> [INFO] --- maven-checkstyle-plugin:3.0.0:check (default) @ >> > > > > > >> > >>> artemis-mqtt-protocol --- >> > > > > > >> > >>> [INFO] >> > > > > > >> > >>> [INFO] --- apache-rat-plugin:0.12:check (default) @ >> > > > artemis-mqtt-protocol >> > > > > > >> > >>> --- >> > > > > > >> > >>> [INFO] RAT will not execute since it is configured to be >> > > > skipped via system >> > > > > > >> > >>> property 'rat.skip'. >> > > > > > >> > >>> [INFO] >> > > > > > >> > >>> [INFO] --- maven-resources-plugin:2.6:testResources >> > > > (default-testResources) >> > > > > > >> > >>> @ artemis-mqtt-protocol --- >> > > > > > >> > >>> [INFO] Using 'UTF-8' encoding to copy filtered resources. >> > > > > > >> > >>> [INFO] Copying 2 resources >> > > > > > >> > >>> [INFO] Copying 3 resources >> > > > > > >> > >>> [INFO] >> > > > > > >> > >>> [INFO] --- maven-compiler-plugin:3.1:testCompile >> > > > (default-testCompile) @ >> > > > > > >> > >>> artemis-mqtt-protocol --- >> > > > > > >> > >>> [INFO] Nothing to compile - all classes are up to date >> > > > > > >> > >>> [INFO] >> > > > > > >> > >>> [INFO] --- maven-surefire-plugin:2.18.1:test >> > (default-test) @ >> > > > > > >> > >>> artemis-mqtt-protocol --- >> > > > > > >> > >>> [INFO] Surefire report directory: >> > > > > > >> > >>> >> > > > >> > C:\Users\bruscinodf\Workspace\brusdev\activemq-artemis\artemis-protocols\artemis-mqtt-protocol\target\surefire-reports >> > > > > > >> > >>> [WARNING] The system property basedir is configured twice! >> > > > The property >> > > > > > >> > >>> appears in <argLine/> and any of >> > <systemPropertyVariables/>, >> > > > > > >> > >>> <systemProperties/> or user property. >> > > > > > >> > >>> >> > > > > > >> > >>> ------------------------------------------------------- >> > > > > > >> > >>> T E S T S >> > > > > > >> > >>> ------------------------------------------------------- >> > > > > > >> > >>> Running >> > > > > > >> > >>> >> > > > >> > org.apache.activemq.artemis.core.protocol.mqtt.MQTTRetainMessageManagerTest >> > > > > > >> > >>> [main] 18:15:31,909 WARN >> > > > [org.apache.activemq.artemis.core.server] >> > > > > > >> > >>> AMQ222018: AIO was not located on this platform, it will >> > fall >> > > > back to using >> > > > > > >> > >>> pure Java NIO. If your platform is Linux, install LibAIO >> > to >> > > > enable the AIO >> > > > > > >> > >>> journal >> > > > > > >> > >>> [main] 18:15:31,928 WARN >> > > > [org.apache.activemq.artemis.core.server] >> > > > > > >> > >>> AMQ222269: Please use a fixed value for >> > "journal-pool-files". >> > > > Default >> > > > > > >> > >>> changed per >> > > > https://issues.apache.org/jira/browse/ARTEMIS-1628 >> > > > > > >> > >>> [main] 18:15:34,505 INFO >> > > > [org.apache.activemq.artemis.core.server] >> > > > > > >> > >>> AMQ221000: live Message Broker is starting with >> > configuration >> > > > Broker >> > > > > > >> > >>> Configuration >> > > > > > >> > >>> >> > > > >> > (clustered=false,journalDirectory=data/journal,bindingsDirectory=data/bindings,largeMessagesDirectory=data/largemessages,pagingDirectory=data/paging) >> > > > > > >> > >>> [main] 18:15:34,526 INFO >> > > > [org.apache.activemq.artemis.core.server] >> > > > > > >> > >>> AMQ221057: Global Max Size is being adjusted to 1/2 of the >> > > > JVM max size >> > > > > > >> > >>> (-Xmx). being defined as 518.979.584 >> > > > > > >> > >>> [main] 18:15:34,554 INFO >> > > > [org.apache.activemq.artemis.core.server] >> > > > > > >> > >>> AMQ221043: Protocol module found: [artemis-server]. Adding >> > > > protocol support >> > > > > > >> > >>> for: CORE >> > > > > > >> > >>> [main] 18:15:34,556 INFO >> > > > [org.apache.activemq.artemis.core.server] >> > > > > > >> > >>> AMQ221043: Protocol module found: [artemis-mqtt-protocol]. >> > > > Adding protocol >> > > > > > >> > >>> support for: MQTT >> > > > > > >> > >>> [main] 18:15:36,138 INFO >> > > > [org.apache.activemq.artemis.core.server] >> > > > > > >> > >>> AMQ221020: Started NIO Acceptor at 127.0.0.1:1883 for >> > > > protocols [MQTT] >> > > > > > >> > >>> [main] 18:15:36,138 INFO >> > > > [org.apache.activemq.artemis.core.server] >> > > > > > >> > >>> AMQ221007: Server is now live >> > > > > > >> > >>> >> > > > > > >> > >>> ... >> > > > > > >> > >>> >> > > > > > >> > >>> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time >> > > > elapsed: 19.839 sec - >> > > > > > >> > >>> in >> > > > > > >> > >>> >> > > > >> > org.apache.activemq.artemis.core.protocol.mqtt.MQTTRetainMessageManagerTest >> > > > > > >> > >>> >> > > > > > >> > >>> Results : >> > > > > > >> > >>> >> > > > > > >> > >>> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0 >> > > > > > >> > >>> >> > > > > > >> > >>> [INFO] >> > > > > > >> > >>> [INFO] --- maven-bundle-plugin:3.0.0:bundle >> > (default-bundle) @ >> > > > > > >> > >>> artemis-mqtt-protocol --- >> > > > > > >> > >>> [INFO] >> > > > > > >> > >>> [INFO] --- maven-site-plugin:3.3:attach-descriptor >> > > > (attach-descriptor) @ >> > > > > > >> > >>> artemis-mqtt-protocol --- >> > > > > > >> > >>> [INFO] >> > > > > > >> > >>> [INFO] --- maven-source-plugin:2.2.1:jar-no-fork >> > > > (attach-sources) @ >> > > > > > >> > >>> artemis-mqtt-protocol --- >> > > > > > >> > >>> [INFO] Building jar: >> > > > > > >> > >>> >> > > > >> > C:\Users\bruscinodf\Workspace\brusdev\activemq-artemis\artemis-protocols\artemis-mqtt-protocol\target\artemis-mqtt-protocol-2.12.0-SNAPSHOT-sources.jar >> > > > > > >> > >>> [INFO] >> > > > > > >> > >>> [INFO] --- dependency-check-maven:1.4.3:check (default) @ >> > > > > > >> > >>> artemis-mqtt-protocol --- >> > > > > > >> > >>> [INFO] Skipping dependency-check >> > > > > > >> > >>> [INFO] >> > > > > > >> > >>> [INFO] --- maven-install-plugin:2.4:install >> > (default-install) >> > > > @ >> > > > > > >> > >>> artemis-mqtt-protocol --- >> > > > > > >> > >>> [INFO] Installing >> > > > > > >> > >>> >> > > > >> > C:\Users\bruscinodf\Workspace\brusdev\activemq-artemis\artemis-protocols\artemis-mqtt-protocol\target\artemis-mqtt-protocol-2.12.0-SNAPSHOT.jar >> > > > > > >> > >>> to >> > > > > > >> > >>> >> > > > >> > C:\Users\bruscinodf\.m2\repository\org\apache\activemq\artemis-mqtt-protocol\2.12.0-SNAPSHOT\artemis-mqtt-protocol-2.12.0-SNAPSHOT.jar >> > > > > > >> > >>> [INFO] Installing >> > > > > > >> > >>> >> > > > >> > C:\Users\bruscinodf\Workspace\brusdev\activemq-artemis\artemis-protocols\artemis-mqtt-protocol\pom.xml >> > > > > > >> > >>> to >> > > > > > >> > >>> >> > > > >> > C:\Users\bruscinodf\.m2\repository\org\apache\activemq\artemis-mqtt-protocol\2.12.0-SNAPSHOT\artemis-mqtt-protocol-2.12.0-SNAPSHOT.pom >> > > > > > >> > >>> [INFO] Installing >> > > > > > >> > >>> >> > > > >> > C:\Users\bruscinodf\Workspace\brusdev\activemq-artemis\artemis-protocols\artemis-mqtt-protocol\target\artemis-mqtt-protocol-2.12.0-SNAPSHOT-sources.jar >> > > > > > >> > >>> to >> > > > > > >> > >>> >> > > > >> > C:\Users\bruscinodf\.m2\repository\org\apache\activemq\artemis-mqtt-protocol\2.12.0-SNAPSHOT\artemis-mqtt-protocol-2.12.0-SNAPSHOT-sources.jar >> > > > > > >> > >>> [INFO] >> > > > > > >> > >>> [INFO] --- maven-bundle-plugin:3.0.0:install >> > > > (default-install) @ >> > > > > > >> > >>> artemis-mqtt-protocol --- >> > > > > > >> > >>> [INFO] Installing >> > > > > > >> > >>> >> > > > >> > org/apache/activemq/artemis-mqtt-protocol/2.12.0-SNAPSHOT/artemis-mqtt-protocol-2.12.0-SNAPSHOT.jar >> > > > > > >> > >>> [INFO] Writing OBR metadata >> > > > > > >> > >>> [INFO] >> > > > > > >> > >>> >> > > > >> > ------------------------------------------------------------------------ >> > > > > > >> > >>> [INFO] BUILD SUCCESS >> > > > > > >> > >>> [INFO] >> > > > > > >> > >>> >> > > > >> > ------------------------------------------------------------------------ >> > > > > > >> > >>> [INFO] Total time: 44.028 s >> > > > > > >> > >>> [INFO] Finished at: 2020-04-08T18:15:54+02:00 >> > > > > > >> > >>> [INFO] >> > > > > > >> > >>> >> > > > >> > ------------------------------------------------------------------------ >> > > > > > >> > >>> >> > > > > > >> > >>> >> > > > > > >> > >>> >> > > > > > >> > >>> >> > > > > > >> > >>> >> > > > > > >> > >>> >> > > > > > >> > >>> -- >> > > > > > >> > >>> Sent from: >> > > > http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html >> > > > > > >> > >> >> > > > > > >> > >> >> > > > > > >> > >> -- >> > > > > > >> > >> Clebert Suconic >> > > > > > >> > > >> > > > > > >> > > >> > > > > > >> > >> > > > > > >> > -- >> > > > > > >> > Tim Bish >> > > > > > >> > >> > > > > > > >> > > > > > > -- >> > > > > > > Clebert Suconic >> > > > > > >> > > > > > >> > > > > > >> > > > > > -- >> > > > > > Clebert Suconic >> > > > > >> > > > > >> > > > > >> > > > > -- >> > > > > Clebert Suconic >> > > > >> > > > >> > >> > >> > >> > -- >> > Clebert Suconic >> > -- Clebert Suconic
