Can I ask again about the seemingly broken errorprone-javac config on
the branch, which looks to be using a non-existent javac.version
property config:
"<arg>-J-Xbootclasspath/p:${settings.localRepository}/com/google/errorprone/javac/${javac.version}/javac-${javac.version}.jarLooking at https://errorprone.info/docs/installation suggests you do need to set the property so the jar can be found, matching whatever dependency the errorprone-core being used is using (which is presumably what will make the javac jar actually get pulled into the local repo at all). It also indicates only doing this config approach on Java 8 because it doesnt work on 9+, so they have an 8-specific profile for it whilst on the branch seems to be happening for all versions. Should it be profiled? On Tue, 2 Jun 2020 at 18:23, Clebert Suconic <clebert.suco...@gmail.com> wrote: > > that's cool.... > > we should move forward then! > > On Tue, Jun 2, 2020 at 1:19 PM Emmanuel Hugonnet <ehugo...@redhat.com> wrote: > > > > error-prone 2.4.0 has been released with JDK 14 and 15 support. > > > > This might answer your question :) > > > > Emmanuel > > > > Le 02/06/2020 à 18:31, Clebert Suconic a écrit : > > > But I think it should be on anything 11+ > > > > > > I would rather avoid having to re-address this again in the future, > > > and be generic enough. > > > > > > > > > What's holding the build on JDK 13? is it error prone for sure or > > > something else? > > > > > > On Tue, Jun 2, 2020 at 5:56 AM Emmanuel Hugonnet <ehugo...@redhat.com> > > > wrote: > > >> Hello, > > >> > > >> I' ve updated my branch and rebased on current master from clebert's > > >> branch. > > >> > > >> It passes a simple build on java 11.0.6 > > >> > > >> Cheers, > > >> > > >> Emmanuel > > >> > > >> Le 08/05/2020 à 19:47, Clebert Suconic a écrit : > > >>> Oh wow.. that's awesome. > > >>> > > >>> > > >>> Can we do the migration after the 2.13.0 release? I have pretty much > > >>> everything ready to go (besides a few changes we have to make next > > >>> week). doing this migration now would probably delay the release. > > >>> > > >>> > > >>> Or you have some requirement for Wildfly that you must do this now? if > > >>> you do we can eventually delay it.. but I would prefer doing it for > > >>> later. > > >>> > > >>> On Fri, May 8, 2020 at 6:24 AM Emmanuel Hugonnet <ehugo...@redhat.com> > > >>> wrote: > > >>>> Hello, > > >>>> > > >>>> When i need to work on Apache ActiveMQ Artemis I need to switch my > > >>>> local environement to use OpenJDK 8 instead of the default OpenJDK 11 > > >>>> which I use to develop. > > >>>> > > >>>> I have started a branch > > >>>> https://github.com/ehsavoie/activemq-artemis/tree/java_11 which builds > > >>>> on OpenJDK 8 and 11 with the fast-tests profile. > > >>>> > > >>>> mvn clean install -Pfast-tests is passing for me locally :) > > >>>> > > >>>> I don't think that the CI or the release should use Java 11 but I hope > > >>>> this will smoothen the time when the migration occurs. > > >>>> > > >>>> Also I couldn't use the --release 8 flag for OpenJDK 11 because of the > > >>>> use of Unsafe, if someone has a better alternative I'm all hears. > > >>>> > > >>>> Do you want me to sumbit a PR for this ? Does this make sense to the > > >>>> community ? > > >>>> > > >>>> Emmanuel > > >>>> > > >>>> > > >>>> > > > > > > > > -- > Clebert Suconic
