another argument to say the thing is written in english, is the names are all english.
I used to work as a consultant in Brazil and my XML names were always in Portuguese for my customers.. so the xml is always in english IMO. On Thu, Jun 11, 2020 at 4:13 PM Clebert Suconic <[email protected]> wrote: > > The xml is written in english. I would say the location should always > be the same no matter where the xml is read. Otherwise you would need > to "translate" the config when you change locales. > > On Thu, Jun 11, 2020 at 2:38 PM Justin Bertram <[email protected]> wrote: > > > > I sent a PR [1] to fix the test. That test is fairly new and since this > > kind of thing hasn't cropped up before I don't think it's a big deal so I'd > > resist imposing anything specific at this point. > > > > > > Justin > > > > [1] https://github.com/apache/activemq-artemis/pull/3178 > > > > > > On Wed, Jun 3, 2020 at 4:50 AM Emmanuel Hugonnet <[email protected]> > > wrote: > > > > > Hello, > > > > > > Sorry I'm French so my locale is FR_fr which makes the current build > > > fails. > > > > > > Failed tests: > > > HumanReadableByteCountTest.test:31 expected:<999[.]0B> but > > > was:<999[,]0B> > > > > > > As you can see this is a really simple failure, that can be easily fixed > > > but I'm wondering about some side effects related to i18n. > > > > > > Does the same kind of issue may occur when parsing the configuration ? > > > Should we impose an US_en format ? > > > > > > Cheers, > > > > > > Emmanuel > > > > > > > > > > > > > -- > Clebert Suconic -- Clebert Suconic
