Cool thanks for the answers Chris and JB! The Maven command in the
activemq-client package was the missing link for 3 and 4. I get a
NullPointerException when I try to run it but I'll play around with it __
Thanks,
Lucas
On 2021-06-08, 4:02 AM, "Jean-Baptiste Onofre" <j...@nanthrax.net> wrote:
CAUTION: This email originated from outside of the organization. Do not
click links or open attachments unless you can confirm the sender and know the
content is safe.
Hi Lucas,
1/ About activemq-openwire module, I think we can remove it.
2/ I don’t think it’s useful, and actually, what about removing
activemq-openwire-legacy. Not sure anyone still use old openwire version.
3/ & 4/ yes, we are generating the openwire via ant (executed/wrapped in
maven). So, definitely worth to keep it ;)
I hope it helps ;)
Regards
JB
> Le 8 juin 2021 à 11:45, Tetreault, Lucas <tetlu...@amazon.com.INVALID> a
écrit :
>
> Hey folks,
>
> I have a few questions about the state OpenWire…
>
> 1/ It looks like there was some attempt to separate it from ActiveMQ
“Classic”:https://github.com/apache/activemq-openwire
<https://github.com/apache/activemq-openwire>. Neither Classic nor Artmemis
appear to use this. Should this repo be archived to avoid confusion?
>
> 2/ The last openwire version to be moved to activemq-openwire-legacy was
v8 in 2013. It looks like v12 was already present in 5.15.0. Should v9, v10 and
v11 be moved to activemq-openwire-legacy? What is actually the benefit of doing
so?
>
> 3/ The openwire marshallers (e.g.:
https://github.com/apache/activemq/blob/main/activemq-client/src/main/java/org/apache/activemq/openwire/v12/ActiveMQBlobMessageMarshaller.java
<https://github.com/apache/activemq/blob/main/activemq-client/src/main/java/org/apache/activemq/openwire/v12/ActiveMQBlobMessageMarshaller.java>)
all include a comment:
>
> * NOTE!: This file is auto generated - do not modify!
> * if you need to make a change, please see the modify the groovy
scripts in the
> * under src/gram/script and then use maven openwire:generate to
regenerate
> * this file.
>
> However, I can’t see how they are auto-generated? E.g.: v12
(https://github.com/apache/activemq/commit/3953b9aaefaee914bdd0702f27aef47c021ceb27
<https://github.com/apache/activemq/commit/3953b9aaefaee914bdd0702f27aef47c021ceb27>)
and v11
(https://github.com/apache/activemq/commit/833d30837b0b306e8d9b0a2e54331c25f7c5c292
<https://github.com/apache/activemq/commit/833d30837b0b306e8d9b0a2e54331c25f7c5c292>)
both appear to be added as a single commit but I can’t see what file would
have been updated to auto-generate the new marshallers? If the files aren’t
auto-generated and those comments are just being copied forward, should they be
removed?
>
> 4/ The activemq-openwire-generator module doesn’t appear to have been
updated in any significant way since 2012 and appears to only generate v2
openwire code. Should the module be deleted?
>
> Lucas Tétreault
> Software Development Manager, Amazon MQ
> email: tetlu...@amazon.com <mailto:tetlu...@amazon.com>
> phone: (778) 222-7107
>
