+1 Bit late, but LGTM
Docker image is helpful, could be a good thing to build automatically in the future! -- Étienne he/him/his On Tue, 3 May 2022, at 2:07 AM, Domenico Francesco Bruscino wrote: > +1 (non binding) > > * Checked parent version in pom.xml files using `grep -LPrz --include > pom.xml "<parent>(.|\n)*<version>2.22.0<\/version>(.|\n)*<\/parent>" ./` > * Ran binary broker instance on Fedora 32 using OpenJDK 11 > * Checked the web console using `Google Chrome` > * Checked producing, browsing and consuming messages from a queue using > `artemis check queue --name TEST --produce 1000 --browse 1000 --consume > 1000` > > On Sat, 30 Apr 2022 at 23:16, Havret <hav...@apache.org> wrote: > >> +1 >> >> I've run the tests against ArtemisNetClient[1]. It's all green. >> >> To make the testing easier, I've created a docker image[2] with the release >> candidate binaries. Feel free to use it to run your tests. >> >> Cheers, >> Krzysztof >> >> [1] https://github.com/Havret/dotnet-activemq-artemis-client/pull/345 >> [2] docker pull >> havret/dotnet-activemq-artemis-client-test-broker:2.22.0-rc1 >> >> On Fri, Apr 29, 2022 at 5:02 PM Justin Bertram <jbert...@apache.org> >> wrote: >> >> > +1 >> > >> > - Ran a few tests >> > - Verified signature and checksum >> > - Built from source >> > >> > >> > Justin >> > >> > On Thu, Apr 28, 2022 at 11:30 AM Clebert Suconic < >> > clebert.suco...@gmail.com> >> > wrote: >> > >> > > I would like to propose an Apache ActiveMQ Artemis 2.22.0 release. >> > > >> > > >> > > There are no new features on this release, however there are many >> > > improvements and bug fixes. >> > > >> > > In particular there's a default change on cluster connections where we >> > > now use 1MB bytes for flow control, avoiding Out Of Memory exception >> > > on situations with high latency networking: >> > > >> > > * ARTEMIS-3083 Set a default producer-window-size on cluster connection >> > > >> > > >> > > There are many other improvements and bug fixes and the full release >> > > notes is available here for more information: >> > > >> > > >> > > >> > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12351488 >> > > >> > > >> > > Ths git commit report is here: >> > > >> > > >> > >> https://activemq.apache.org/components/artemis/download/commit-report-2.22.0 >> > > >> > > >> > > Source and binary distributions can be found here: >> > > >> https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis/2.22.0 >> > > >> > > The Maven staged repository is here: >> > > >> > >> https://repository.apache.org/content/repositories/orgapacheactivemq-1251 >> > > >> > > >> > > In case you want to give it a try with the maven repo on examples: >> > > >> > > >> > >> https://activemq.apache.org/components/artemis/documentation/hacking-guide/validating-releases.html >> > > >> > > >> > > The source tag: >> > > >> > > >> > > >> > >> https://gitbox.apache.org/repos/asf/activemq-artemis.git;a=tag;h=refs/tags/2.22.0 >> > > >> > > >> > > [ ] +1 approve this release >> > > [ ] +0 no opinion >> > > [ ] -1 disapprove (and reason why) >> > > >> > > >> > > Here's my +1 (Binding) vote >> > > >> > > >> > > >> > > I should keep this release open for 72 Hours, and I'm not going to >> > > count the weekend as business hours. That means I will keep this >> > > release open until at least May-3rd, Noon USA EST. >> > > >> > > >> > >>
