+1 Cheers, Jamie
On Tue, Mar 21, 2023 at 8:27 AM Christopher Shannon <christopher.l.shan...@gmail.com> wrote: > > +1 (binding) > > Overall things look pretty good to me. > > * Validated signatures and checksums > * Verified license and notice files in archives > * Checked source license headers with 'mvn apache-rat:check' > * Built from source archive and ran several automated custom tests to > verify things look good > * Ran the broker from the binary archive and exercised the web console > > As a side note I did notice one issue that showed up with the slf4j2 > upgrade. It looks like the activemq-partition module has a compile time > dependency on the log4j2 impl jar. This caused an issue when I first > updated in a project that used slf4j1 as it pulled in the transitive > dependency so I ended up with both impls on the classpath. This dependency > should only be test scope (like all the other modules) except for the > assembly jar, of course. > > While we should fix this in my opinion I don't think we need to stop the > vote and can just fix it in 5.18.1 and 5.19.0 unless others object because: > > A) the binary distribution still works fine as it only is in issue if you > have dependency on that module > B) This has been an issue for a while going back to slf4j1, it just shows > up now because of the upgrade > C) activemq-partition is essentially deprecated and useless so is > probably not widely used and should be removed in the future. It was almost > removed when we removed LevelDB as it doesn't really serve much purpose. > 4) If it's a problem for someone they should be able to easily add an > exclusion on that transitive dependency > > On Sun, Mar 19, 2023 at 1:27 PM Jean-Baptiste Onofré <j...@nanthrax.net> > wrote: > > > Hi, > > > > After several weeks of work, I'm glad to submit ActiveMQ 5.18.0 to > > your vote. This release is a major milestone for ActiveMQ bringing > > major changes: > > - JMS 2 API support (client) > > - support Jakarta namespace (client) > > - a lot of dependency updates and fixes > > - and much much more! > > > > You can take a look on the Release Notes for details: > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12351380 > > > > Maven Staging Repository: > > https://repository.apache.org/content/repositories/orgapacheactivemq-1275/ > > > > Dist Staging Repository: > > https://dist.apache.org/repos/dist/dev/activemq/activemq/5.18.0/ > > > > Git tag: activemq-5.18.0 > > > > Please vote to approve this release: > > [ ] +1 Approve the release > > [ ] -1 Don't approve the release (please provide specific comments) > > > > This vote will be open for at least 72 hours. > > > > Thanks ! > > Regards > > JB > >
