I was going to vote positively, but after seeing the earlier mails and trying things out further I see the same issue as Matt has reported.
The quotes added on this line: https://github.com/apache/activemq/blob/6bae734088d70b8e1a72ab6f3a763199d38af306/assembly/src/release/bin/activemq#L174 in https://github.com/apache/activemq/pull/1162 breaks loading of the setenv config (and presumably the earlier config paths if they were present). With the quotes in place, I edited the setenv file to also set a custom system property, and observed that it wasnt applied due to the setenv file not being used and the "INFO: Using default configuration" message Matt referenced below being printed. Removing the quotes on that line, the setenv config was actually found and used (and my custom property in it was then set on the JVM): INFO: Loading '/path/to/6.1.0-rc1/apache-activemq-6.1.0//bin/setenv' (I wasnt using a dir with spaces) Robbie On Thu, 7 Mar 2024 at 21:48, Matt Pavlovich <mattr...@gmail.com> wrote: > > Heads up— while working on another fix, I may have stubbled on a regression > caused by the change below and may need to revert my +1 to a -1 > > Support space in filename: > https://github.com/apache/activemq/pull/1162 > > INFO: Using default configuration > Configurations are loaded in the following order: /etc/default/activemq > /Users/activemq/.activemqrc > "/Users/activemq/apache-activemq-6.1.0/"/bin/setenv > > This appears to cause the setenv to not be sourced and configs (such as JAAS > login.config and JMX settings are not picked up at boot) > > I’m doing some additional testing and will report back, but I believe we need > to hold the release until this is verified. > > Thanks, > Matt > > > On Mar 7, 2024, at 2:05 PM, Matt Pavlovich <mattr...@gmail.com> wrote: > > > > +1 (binding) > > > > - Downloaded dist tar.gz archive and confirmed various configurations using > > JDK 21 > > - Tested web console demo examples > > - Tested web console functions > > - Reviewed JIRA and release notes > > > > Thanks, > > Matt Pavlovich > > > >> On Mar 5, 2024, at 11:38 AM, Jean-Baptiste Onofré <j...@nanthrax.net> > >> wrote: > >> > >> Hi guys, > >> > >> I submit Apache ActiveMQ "Classic" 6.1.0 release to your vote. > >> > >> This release includes: > >> - New JMS2/3 operations support > >> - Mapping javax / jakarta exception in openwire protocol > >> - Add destination field on the job scheduler > >> - Add org.apache.activemq.broker.BouncyCastleNotAdded property to > >> control the bouncycastle addition in BrokerService classloader > >> - Dependency upgrades (Spring 6.1.4, log4j 2.23.0, Jetty 11.0.20, ...) > >> - and a lot more ! > >> > >> You can take a look on Release Notes for details: > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12353745 > >> > >> Maven Staging Repository: > >> https://repository.apache.org/content/repositories/orgapacheactivemq-1387/ > >> > >> Dist Staging Repository: > >> https://dist.apache.org/repos/dist/dev/activemq/activemq/6.1.0/ > >> > >> Git tag: activemq-6.1.0 > >> > >> Please vote to approve this release: > >> [ ] +1 Approve the release > >> [ ] -1 Don't approve the release (please provide specific comments) > >> > >> This vote will be open for at least 72 hours. > >> > >> Thanks ! > >> Regards > >> JB > > >
