The Vote has passed with 8 Votes (7 PMC + 1 Committer) PMC Votes (Binding) Clebert Suconic JB Onofre Justin Bertram Gary Tully Domenico Bruscino Havret (Krzysztof) Christopher shannon
Commiter Votes (Non Binding) Anton Roskvist Thank you all for your time evaluating this release. i will go ahead and deploy the release on the website. I will post an announce when everything is ready. On Sat, Jun 1, 2024 at 4:02 PM Havret <hav...@apache.org> wrote: > > Hi, > > I've re-evaluated the process since it's been a while since I last built an > Artemis Docker image. It appears that I used the incorrect command. > Initially, I used: > > docker build -t > havret/dotnet-activemq-artemis-client-test-broker:2.34.0-rc1 . > > Instead of the correct: > > docker buildx build --platform linux/amd64,linux/arm64 -t > havret/dotnet-activemq-artemis-client-test-broker:2.34.0-rc1 --push . > > As a result, I was running the broker in Docker via emulation on my M1 > chip. With the proper arm64 build, it stopped crashing. > > I apologize for any confusion caused and for the premature concern. > > I would like to reinstate my "+1 (binding)" vote. > > Best regards, > > Krzysztof > > On Sat, Jun 1, 2024 at 9:35 PM Clebert Suconic <clebert.suco...@gmail.com> > wrote: > > > Not necessarily an issue. > > > > I for instance increased the possible throughout of paging by > > https://issues.apache.org/jira/browse/ARTEMIS-4773 > > > > if you don't configure the max-read-pages while fetching from page you > > might endup with more messages than you can handle in memory. > > > > > > The VM should be issuing an OME on that case.. but a crash / core dump is > > definitely not a broker issue. > > > > try including max-read-page-messages to 2000 and prefetch-page-messages to > > 100 and tell me the results. > > > > > > I do test adding millions of messages on the broker by some of the soak > > tests I added (I can tweak numbers) and it's definitely not an issue. > > > > > > If you reproduce the issue and provide me info I can check better. > > > > > > Clebert Suconic > > > > > > On Sat, Jun 1, 2024 at 6:40 AM Havret <hav...@apache.org> wrote: > > > > > Hi Clebert, Justin, > > > > > > I've checked the previous version (2.33.0), as Justin suggested, and it's > > > working fine. However, with the current release candidate, it keeps > > > crashing every single time on a simple throughput benchmark (I'm sending > > > 100k messages with 1KB of payload each). This issue occurs with both AMQP > > > and CORE protocols. > > > > > > Having said that, I'm changing my vote to: > > > > > > -1 (binding) > > > > > > Thanks, > > > Krzysztof > > > > > > On Sat, Jun 1, 2024 at 07:07 Clebert Suconic <clebert.suco...@gmail.com> > > > wrote: > > > > > > > I would take it separately from the Vote thread" I don't see anything > > > > wrong with the release itself. > > > > > > > > if you could start a separate thread about the issue, how to reproduce > > > > it. When it started to fail? configurations.. etc? > > > > > > > > > > > > this error here: > > > > G1ParScanThreadState::copy_to_survivor_space(G1HeapRegionAttr, > > oopDesc*, > > > > > > > > > > > > Suggests me it's a memory issue? I would start by looking at paging > > > > and its configurations? but lets do that on a separate thread? > > > > > > > > On Fri, May 31, 2024 at 6:54 PM Havret <h4v...@gmail.com> wrote: > > > > > > > > > > I just noticed that when I run my performance benchmark against > > version > > > > > 2.34.0, it crashes with the following error: > > > > > > > > > > activemq-artemis | [thread 14 also had an error] > > > > > activemq-artemis | # > > > > > activemq-artemis | # A fatal error has been detected by the Java > > > Runtime > > > > > Environment: > > > > > activemq-artemis | # > > > > > activemq-artemis | # SIGSEGV (0xb) at pc=0x00007ffffe73b0d3, pid=1, > > > > tid=37 > > > > > activemq-artemis | # > > > > > activemq-artemis | # JRE version: OpenJDK Runtime Environment > > > > > Zulu14.29+23-CA (14.0.2+12) (build 14.0.2+12) > > > > > activemq-artemis | # Java VM: OpenJDK 64-Bit Server VM > > Zulu14.29+23-CA > > > > > (14.0.2+12, mixed mode, sharing, tiered, compressed oops, g1 gc, > > > > > linux-amd64) > > > > > activemq-artemis | # Problematic frame: > > > > > activemq-artemis | # V [libjvm.so+0x6ee0d3][thread 40 also had an > > > > error] > > > > > activemq-artemis | [thread 36 also had an error] > > > > > activemq-artemis | [thread 39 also had an error] > > > > > activemq-artemis | [thread 34 also had an error] > > > > > activemq-artemis | [thread 33 also had an error] > > > > > activemq-artemis | [thread 35 also had an error] > > > > > activemq-artemis | [thread 38 also had an error] > > > > > activemq-artemis | > > > > > G1ParScanThreadState::copy_to_survivor_space(G1HeapRegionAttr, > > > oopDesc*, > > > > > markWord)+0x283 > > > > > activemq-artemis | # > > > > > activemq-artemis | # No core dump will be written. Core dumps have > > > been > > > > > disabled. To enable core dumping, try "ulimit -c unlimited" before > > > > starting > > > > > Java again > > > > > activemq-artemis | # > > > > > activemq-artemis | # An error report file with more information is > > > saved > > > > > as: > > > > > activemq-artemis | # /artemis/hs_err_pid1.log > > > > > activemq-artemis | # > > > > > activemq-artemis | # If you would like to submit a bug report, > > please > > > > > visit: > > > > > activemq-artemis | # http://www.azulsystems.com/support/ > > > > > activemq-artemis | # > > > > > > > > > > With 2.30.0 It's working fine. > > > > > > > > > > Thanks, > > > > > Krzysztof > > > > > > > > > > > > > > > On Fri, May 31, 2024 at 8:16 PM Havret <hav...@apache.org> wrote: > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > I've run the tests against ArtemisNetClient[1] 2.12.0 and > > > > > > ArtemisNetCoreClient 1.0.0-alpha.1[2]. It's all green. > > > > > > > > > > > > To make the testing easier, I've created a docker image[3] with the > > > > > > release candidate binaries. Feel free to use it to run your tests. > > > > > > > > > > > > Cheers, > > > > > > Krzysztof > > > > > > > > > > > > [1] > > > https://github.com/Havret/dotnet-activemq-artemis-client/pull/490 > > > > > > [2] > > > > https://github.com/Havret/dotnet-activemq-artemis-core-client/pull/115 > > > > > > [3] docker pull > > > > > > havret/dotnet-activemq-artemis-client-test-broker:2.34.0-rc1 > > > > > > > > > > > > On Fri, May 31, 2024 at 6:56 PM Domenico Francesco Bruscino < > > > > > > bruscin...@gmail.com> wrote: > > > > > > > > > > > >> +1 (binding) > > > > > >> > > > > > >> * Checked parent version in pom.xml files using `grep -LPrz > > > --include > > > > > >> pom.xml > > "<parent>(.|\n)*<version>2.34.0<\/version>(.|\n)*<\/parent>" > > > > ./` > > > > > >> * Ran binary broker instance on Fedora 38 using OpenJDK 17 > > > > > >> * Checked the web console using `Google Chrome` > > > > > >> * Checked producing, browsing and consuming messages from a queue > > > > using > > > > > >> `artemis check queue --name TEST --produce 1000 --browse 1000 > > > > --consume > > > > > >> 1000` > > > > > >> > > > > > >> Connection brokerURL = tcp://localhost:61616 > > > > > >> Running QueueCheck > > > > > >> Checking that a producer can send 1000 messages to the queue TEST > > > ... > > > > > >> success > > > > > >> Checking that a consumer can browse 1000 messages from the queue > > > TEST > > > > ... > > > > > >> success > > > > > >> Checking that a consumer can consume 1000 messages from the queue > > > > TEST ... > > > > > >> success > > > > > >> Checks run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: > > > > 2.842 sec > > > > > >> - QueueCheck > > > > > >> > > > > > >> On Wed, 29 May 2024 at 19:43, Clebert Suconic < > > > > clebert.suco...@gmail.com> > > > > > >> wrote: > > > > > >> > > > > > >> > I would like to propose an Apache ActiveMQ Artemis 2.34.0 > > release. > > > > > >> > > > > > > >> > > > > > > >> > I would like to highlight the following improvements as part of > > > this > > > > > >> > release: > > > > > >> > > > > > > >> > * https://issues.apache.org/jira/browse/ARTEMIS-4758 - > > Extensive > > > > > >> > resiliency tests and hardening on Mirroring. > > > > > >> > * https://issues.apache.org/jira/browse/ARTEMIS-4773 - Paging > > > > > >> > performance improvements on sync. > > > > > >> > * https://issues.apache.org/jira/browse/ARTEMIS-4306 - Statics > > > > about > > > > > >> > security events > > > > > >> > * https://issues.apache.org/jira/browse/ARTEMIS-4675 - > > > Replication > > > > > >> > status metrics > > > > > >> > > > > > > >> > > > > > > >> > For a full release notes: > > > > > >> > > > > > > >> > > > > > > >> > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12354426 > > > > > >> > > > > > > >> > The commit report: > > > > > >> > > > > > > >> > > > > > > >> > > > > > > > > > https://activemq.apache.org/components/artemis/download/commit-report-2.34.0 > > > > > >> > > > > > > >> > Source and binary distributions can be found here: > > > > > >> > > > > > > >> > > > > > > https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis/2.34.0/ > > > > > >> > > > > > > >> > > > > > > >> > The Maven staged repository is here: > > > > > >> > > > > > > >> > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheactivemq-1396 > > > > > >> > > > > > > >> > If you would like to validate the release: > > > > > >> > > > > > > >> > > > > > > >> > > > > > > > > > https://activemq.apache.org/components/artemis/documentation/hacking-guide/#validating-releases > > > > > >> > > > > > > >> > > > > > > >> > It is tagged in the git repo as 2.34.0 > > > > > >> > > > > > > >> > If you could please vote as usually: > > > > > >> > > > > > > >> > [ ] +1 approve this release > > > > > >> > [ ] +0 no opinion > > > > > >> > [ ] -1 disapprove (and reason why) > > > > > >> > > > > > > >> > > > > > --------------------------------------------------------------------- > > > > > >> > To unsubscribe, e-mail: dev-unsubscr...@activemq.apache.org > > > > > >> > For additional commands, e-mail: dev-h...@activemq.apache.org > > > > > >> > For further information, visit: > > > https://activemq.apache.org/contact > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > -- > > > > Clebert Suconic > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: dev-unsubscr...@activemq.apache.org > > > > For additional commands, e-mail: dev-h...@activemq.apache.org > > > > For further information, visit: https://activemq.apache.org/contact > > > > > > > > > > > > > > > > > -- Clebert Suconic --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@activemq.apache.org For additional commands, e-mail: dev-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
