I raised https://github.com/apache/activemq-artemis-console/pull/34 to address the missing license file in the source release archive, and improve the rat plugin config to allow simple manual verifications.
On Mon, 30 Sept 2024 at 17:41, Robbie Gemmell <robbie.gemm...@gmail.com> wrote: > > -1 > > Overall it looks good, however the source archive LICENCE file > references a sub file that isnt actually included in the archive > (artemis-console-extension/artemis-extension/.yarn/releases/LICENSE-yarn.txt). > It is in the repo, it is just a trivial issue with the assembly > creation process including 1 file out of this build-updated-dir > instead of the two that it should have; trivial fix is to also include > the other file. > > I checked things over as follows: > - I verified the signature and checksum files. > > - I checked for licence+notice files in the archives. I noticed the > above lissue first. Another niggle in the space of licences, but just > an annoyance not a blocker, is that the RAT plugin config could be > improved so that it applied to manual CLI invocations as well as the > standard build. RAT is always being run as part of the build, which is > perhaps unnecessary but not a big overhead in this case, however the > config for that is specific to that execution and so if instead > manually running "mvn apache-rat:check" on the CLI to verify things > specifically, it then fails because a couple of .md files (e.g > README.md for one) dont get excluded like they are during the > execution within the regular build cycle. They should just share the > same config. > > - I gave the source build a run, and started up the console standalone > using the jetty maven plugin per the readme, connecting it to a > running 2.37.0 artemis instance. > > - I also tried the modified-2.37.0 integration from the draft PR > https://github.com/apache/activemq-artemis/pull/5245. I noticed some > issues with that, all on the main artemis repo side, which I pushed > some commits to resolve some of and commented on the rest. With the > fixes I made in place, I also tried running the upgrade command from > the branch to update an existing 2.37.0 instance to the modified > variant with new console. > > Robbie > > On Mon, 23 Sept 2024 at 14:47, Andy Taylor <andy.tayl...@gmail.com> wrote: > > > > I would like to propose an Apache ActiveMQ Artemis Console 1.0.0 release. > > > > This is the 1st release of the ActiveMQ Console so only has 1 jira > > > > [ARTEMIS-4680] - Upgrade the console to use HawtIO 4 > > > > The release notes can be found here: > > https://issues.apache.org/jira/projects/ARTEMIS/versions/12354639 > > > > Source and Binary distributions can be found here: > > https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis-console/1.0.0/ > > > > The Maven staging repository is here: > > https://repository.apache.org/content/repositories/orgapacheactivemq-1405 > > > > If you would like to validate the release you can either: > > > > 1. Check out the source, build and follow the readme instructions > > (README.md) to deploy and smoke test the console > > > > or > > > > 2. Download the binary distribution and deploy in a we container > > > > or > > > > 3. Use a branch I have created based on Artemis 2.37.0 to build Artemis > > with the console embedded, see > > https://github.com/apache/activemq-artemis/pull/5245 > > > > > > It is tagged in the git repo as 1.0.0 > > > > [ ] +1 approve this release > > [ ] +0 no opinion > > [ ] -1 disapprove (and reason why) > > > > Here's my +1 --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@activemq.apache.org For additional commands, e-mail: dev-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
