Hi Ken That’s a good point.
As we don’t have much change there, I think it’s reasonable to have the generate source code in the repo and remove the javacc dependency. +1 from me. Thanks Regards JB Le ven. 17 janv. 2025 à 10:41, Ken Liao <kenlia...@gmail.com> a écrit : > Hi folks, > > Recently, I am diving into the SelectorParser.java generated by javacc. I > am wondering, do we want to keep maintaining javacc as a dependency of the > activemq-client package? > > In another word, the grammar of the JMS selector hasn't changed (last time > the change made to the grammar definition file SelectorParser.jj is > changing the namespace to jakarta in the main branch). Would it be easier > to just commit the generated java file as source and remove the javacc > dependency? > > If we do want to keep it as a dependency, the latest stable release of > javacc is version 7. I can upgrade javacc to version 7 to check if it > breaks the build and tests. I will create a PR on it soon if there's no > objection. > > Thanks, > Ken >
