+1 (binding), looks good to me On Mon, Mar 10, 2025 at 3:28 PM Jean-Baptiste Onofré <j...@nanthrax.net> wrote: > > Hi Matt > > No 5.19.0 was made with JDK11 (same as 5.18.x). > > I always align the JDK used for release with the one defined for > compiler target. > For 5.19.0, it's JDK11: > https://github.com/apache/activemq/blob/activemq-5.19.x/pom.xml#L122 > > Regards > JB > > On Mon, Mar 10, 2025 at 6:50 PM Matt Pavlovich <mattr...@apache.org> wrote: > > > > JB- > > > > Was the 5.19.0 release built with JDK 17? The reproducible build only > > succeeds when testing with JDK 17. > > > > I know we source/target for JDK 11. I’m not aware of specific guidance of > > which JDK major version should be used when creating a build. > > > > Given this— there is a risk that the built binaries have optimizations not > > supported by a JDK 11 runtime, since we do not compile with the ‘release’ > > flag: https://openjdk.org/jeps/247 > > > > Thanks, > > Matt Pavlovich > > > > > On Mar 7, 2025, at 9:28 AM, Jean-Baptiste Onofré <j...@nanthrax.net> > > > wrote: > > > > > > Hi folks, > > > > > > I submit Apache ActiveMQ Classic 5.19.0 release to your vote. > > > > > > This release is the first one on the 5.19.x series. This is based on > > > 5.18.x, adding some new features. > > > > > > This release includes: > > > - fix potential OutOfMemory error on client during OpenWire unmarshalling > > > - improvement on double slashes in Unix scripts > > > - fix ClassCastException in SelectorAwareVirtualTopicInterceptor if > > > there is another interceptor > > > - fix on WebConsole, checking if a queue exists before being able to > > > browse it > > > - fix durable subscriber receives acknowledge messages if they are > > > farther than the maxBatchSize > > > - update ConnectionView to include WireFormatInfo > > > - add the ability to disable connector startup on boot > > > - add advancedMessageStatistics to destinations > > > - several dependency updates > > > > > > You can take a look on the Release Notes for details: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12355096 > > > > > > Staging Maven Repository: > > > https://repository.apache.org/content/repositories/orgapacheactivemq-1423/ > > > > > > Staging Dist Repository: > > > https://dist.apache.org/repos/dist/dev/activemq/activemq/5.19.0/ > > > > > > Git tag: > > > activemq-5.19.0 > > > > > > Please vote to approve this release: > > > [ ] +1 Approve the release > > > [ ] 0 I don't care > > > [ ] -1 Don't approve the release (please provide specific comment) > > > > > > This vote will be open for at least 72 hours. > > > > > > Thanks! > > > Regards > > > JB > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@activemq.apache.org > > > For additional commands, e-mail: dev-h...@activemq.apache.org > > > For further information, visit: https://activemq.apache.org/contact > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@activemq.apache.org > > For additional commands, e-mail: dev-h...@activemq.apache.org > > For further information, visit: https://activemq.apache.org/contact > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@activemq.apache.org > For additional commands, e-mail: dev-h...@activemq.apache.org > For further information, visit: https://activemq.apache.org/contact > >
--------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@activemq.apache.org For additional commands, e-mail: dev-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
