I see thanks for the info JB and Chris. I will look into that package and see what I can do to contribute. What is the status of that activemq-openwire package?
Thanks, Ken On Mon, Apr 7, 2025 at 12:37 PM Christopher Shannon < christopher.l.shan...@gmail.com> wrote: > There's also a Jira project for Openwire: > https://issues.apache.org/jira/projects/OPENWIRE/issues/ > > On Mon, Apr 7, 2025 at 3:25 PM Christopher Shannon > <christopher.l.shan...@gmail.com> wrote: > > > > The OpenWire generator is no longer going to be used and is very out > > of date because of the lack of JDK 11 and JDK 17 support. > > > > The plan for v13 is to use this project that Tim started a long time > > ago and recently Matt and I have been working to bring up to date: > > https://github.com/apache/activemq-openwire > > > > The goal with that project is to use more modern annotations and to > > share code between implementations. > > > > > > > > On Tue, Apr 1, 2025 at 1:31 AM Jean-Baptiste Onofré <j...@nanthrax.net> > wrote: > > > > > > Yes both generator and client profile still need jdk8. > > > I will work on another Pr for jdk17 support. > > > > > > Regards > > > JB > > > > > > Le lun. 31 mars 2025 à 23:15, Ken Liao <kenlia...@gmail.com> a écrit : > > > > > > > Thanks for the PR JB! > > > > > > > > So do we keep using Java 8 for the generator going forward? Should > we come > > > > up with a long term improvement for that part of the codebase? > > > > > > > > Thanks, > > > > Ken > > > > > > > > On Sun, Mar 30, 2025 at 1:51 AM Jean-Baptiste Onofré < > j...@nanthrax.net> > > > > wrote: > > > > > > > > > Hi Ken > > > > > > > > > > 1. Yes legacy should stay there and not changed. > > > > > 2. I don't think we have such page. I know only > > > > > > https://activemq.apache.org/components/classic/documentation/openwire > > > > > and > > > > > > > > > > https://activemq.apache.org/components/classic/documentation/openwire-version-2-specification > > > > > pages, but probably not up to date :) > > > > > 3. The client only generates on-demand (using the corresponding > > > > > profile), when a new openwire version is available. The "break" on > > > > > antrun is new due to update to Apache POM 33/34 and use the plugin > > > > > versions from there. I'm an easy fix to do: we have to use target > > > > > instead of tasks (I fixed that in other module but forgot this > > > > > profile). Let me create a PR to fix that. > > > > > > > > > > Regards > > > > > JB > > > > > > > > > > On Fri, Mar 28, 2025 at 7:39 PM Ken Liao <kenlia...@gmail.com> > wrote: > > > > > > > > > > > > Hi folks, > > > > > > > > > > > > I am experimenting with OpenWire and trying to create a V13 of > the > > > > > > protocol. I added my changes to the sub classes of BaseCommand. > > > > > However, I > > > > > > have trouble kicking off the openwire generation (I vaguely > remember it > > > > > was > > > > > > discussed somewhere that the current generator is broken?) to > > > > > auto-generate > > > > > > the marshaller. I have a few questions: > > > > > > > > > > > > 1. `activemq-opernwire-legacy` is kept around for reference and > we > > > > should > > > > > > not touch it, correct ? > > > > > > 2. Is there a page that lists what major and minor version at > which > > > > each > > > > > > version of OpenWire protocol was introduced? > > > > > > 3. So `activemq-client` has a task > > > > > > < > > > > > > > > > > https://github.com/apache/activemq/blob/e39e611b4422b65fa4fd6c9c3a88b76a1fd836f7/activemq-client/pom.xml#L320 > > > > > > > > > > > > to generate it but apparently it is broken with the error > message "You > > > > > are > > > > > > using 'tasks' which has been removed from the > maven-antrun-plugin". > > > > > Should > > > > > > I remove it from that package? Alternatively, there is a package > called > > > > > > "activemq-openwire-generator" but itself doesn't have any task > but It > > > > is > > > > > > imported by activemq-client. So should I fix it in the > activemq-client > > > > > > package instead? > > > > > > > > > > > > Thank you for your help! > > > > > > > > > > > > Thanks, > > > > > > Ken > > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: dev-unsubscr...@activemq.apache.org > > > > > For additional commands, e-mail: dev-h...@activemq.apache.org > > > > > For further information, visit: > https://activemq.apache.org/contact > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@activemq.apache.org > For additional commands, e-mail: dev-h...@activemq.apache.org > For further information, visit: https://activemq.apache.org/contact > > >
