Thanks for the review and the fix, Robbie.

I'm cancelling this vote and I'll re-spin.


Justin

On Fri, Jul 11, 2025 at 10:17 AM Robbie Gemmell <robbie.gemm...@gmail.com>
wrote:

> I pushed a fix for the issue I noticed with the assembly:
>
> https://github.com/apache/activemq-artemis/commit/ba6ed9c14fe6f48aab28a66f953d80e7aff6c87f
>
> On Fri, 11 Jul 2025 at 14:08, Robbie Gemmell <robbie.gemm...@gmail.com>
> wrote:
> >
> > -1
> >
> > The binary assembly is missing the sub-referenced file relating to
> > console dep licences. Looks like a build tweak is required to ensure
> > it always gets included (seems like a profile-activation ordering
> > issue, as it does some of the time).
> >
> > I checked things over as follows:
> > - Verified the signature and checksum files.
> > - Checked for LICENCE + NOTICE files in archives (saw issue as above).
> > - Checked licence headers in the source archive by running:
> >   "mvn apache-rat:check"
> > - Ran the Qpid JMS 2.8.0-SNAPSHOT HelloWorld against a broker from the
> > binary archive on JDK 21.
> > - Ran the source build and the AMQP integration tests on JDK 17 with a
> > fresh local repo using:
> >   "mvn clean install -DskipTests && cd tests/integration-tests/ && mvn
> > -Ptests -Dtest=org.apache.activemq.artemis.tests.integration.amqp.**
> > test"
> >
> > Robbie
> >
> > On Tue, 8 Jul 2025 at 20:14, Justin Bertram <jbert...@apache.org> wrote:
> > >
> > > I would like to propose an Apache ActiveMQ Artemis 2.42.0 release.
> > >
> > > Highlights include:
> > >
> > >  - Apply security-setting configuration according to uuid-namespace.
> > >  - Control the maximum number of in-flight MQTT messages for both 3.x
> and
> > > 5.0 clients via defaultMaximumInFlightPublishMessages.
> > >  - MQTT performance improvements for:
> > >     - persisting subscriptions
> > >     - matching subscription identifiers to topic filters for 5.0
> clients
> > >  - Upgrade to ActiveMQ Artemis Console 1.2.1 with lots of usability
> > > improvements
> > >  - And for developers…almost 2,500 lines of code were eliminated by
> > > consistently using the convenience methods from Java’s
> java.util.Objects
> > > class across the code-base (e.g. hash, toString, equals,
> requireNonNull,
> > > etc.).
> > >
> > > * Full release notes:
> > >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12355900
> > >
> > > * Commit report:
> > >
> https://activemq.apache.org/components/artemis/download/commit-report-2.42.0
> > >
> > > * Source and binary distributions:
> > >
> https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis/2.42.0/
> > >
> > > * Maven staging repository:
> > >
> https://repository.apache.org/content/repositories/orgapacheactivemq-1433
> > >
> > > * How to validate the release:
> > >
> https://activemq.apache.org/components/artemis/documentation/hacking-guide/#validating-releases
> > >
> > > It is tagged in the source repo as 2.42.0.
> > >
> > > This vote will stay open until at least July 11.
> > >
> > > [ ] +1 approve this release
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove (and reason why)
> > >
> > > Here's my +1
> > >
> > >
> > > Justin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@activemq.apache.org
> For additional commands, e-mail: dev-h...@activemq.apache.org
> For further information, visit: https://activemq.apache.org/contact
>
>
>

Reply via email to