Yup. It looks great to me. Merge on main is good enough (no need to
backport).

I will test multi Java version to see how it works with 17, 22, 25.

Regards
JB

Le mer. 4 févr. 2026 à 20:04, Matt Pavlovich <[email protected]> a écrit :

> I made a quick pass and overall it is in good shape. I need to to complete
> full review.
>
> Quick notes — main is already 6.3.0-SNAPSHOT, so once reviewed it will
> merge into main just fine (no back ports)
>
> Thanks!
>
> > On Feb 4, 2026, at 11:15 AM, Jean-Louis Monteiro <
> [email protected]> wrote:
> >
> > Hi team,
> >
> > With all the other fixes (flaky tests and bugs), the PR on Java 25 is
> > passing and green.
> > Aside from the MRJAR and the SecurityManager removal, the rest is almost
> > only setup which is great in my opinion.
> >
> > I'll rebase it and hope it stays green. I'd appreciate additional review.
> > Matt, we worked on it together, so any feedback would be awesome.
> > JB: Would you mind merging it or do you prefer to wait for 6.3.x?
> >
> >
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Tue, Jan 27, 2026 at 10:10 PM Jean-Baptiste Onofré <[email protected]>
> > wrote:
> >
> >> Hi
> >>
> >> As reminder, the plan is:
> >> - Java 17 min for 6.2.x (no explicit Java 25 support)
> >> - Java 11 min for 5.19.x (no explicit Java 25 support)
> >>
> >> I think we should keep Java 17 for 6.3.x for now, and support Java 25 as
> >> best effort.
> >> I'm in favor of adding 25 in the matrix for main (6.3.x for now).
> >>
> >> Regards
> >> JB
> >>
> >> On Mon, Jan 26, 2026 at 11:39 AM Jean-Louis Monteiro <
> >> [email protected]> wrote:
> >>
> >>> Hi all,
> >>>
> >>> Following up on this topic.
> >>>
> >>> I pulled the initial work from Matt and I related to the Security
> Manager
> >>> and the MRJAR. I've continued the work into a PR I was able to
> contribute
> >>> to and build on my own.
> >>>
> >>> It's green when running on Java 17 and Java 21 for compile.
> >>> It's green for tests on Java 17
> >>>
> >>> I'll rebase it and temporarily move the tests to run on Java 25 and add
> >> 25
> >>> to the compile matrix. Whenever the PR is green, we need to put 17 back
> >> for
> >>> quick and 25 will run nightly.
> >>>
> >>> --
> >>> Jean-Louis Monteiro
> >>> http://twitter.com/jlouismonteiro
> >>> http://www.tomitribe.com
> >>>
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
> For further information, visit: https://activemq.apache.org/contact
>
>
>

Reply via email to