Hi all, Our setup requires PRs to be reviewed, which I think is good. We also have a bot to mark old PRs as stale and closes them, which is also a good thing.
Now, we need to be diligent reviewing PRs. For instance, I had to remove the stale label from my PRs to prevent them from being closed. I'd appreciate some help reviewing my PRs if possible. https://github.com/apache/activemq/pull/1541 --> MQTT module changes similar to the other modules. It aims to run eligible tests in parallel. At first glance, there is no breaking change. We are running the same tests as before. We've merged all other PRs, so this module is the same. CI is green. https://github.com/apache/activemq/pull/1661 --> simple PR to enable wiring the SSL context into the ManagementContext. A user opened another PR. I'm not sure if we need both. This relates to feature request AMQ-9857 https://github.com/apache/activemq/pull/1711 --> flaky tests again. I keep opening and fixing tests as we go. Sometimes, tests require various incremental fixes. I apologize for that but it's difficult to reproduce the exact conditions locally to make the tests fail. https://github.com/apache/activemq/pull/1712 --> Jakarta TCK setup into its own module. No impact, TCK won't run unless you add the profile. https://github.com/apache/activemq/pull/1666 --> race condition on the exception and transport listener. https://github.com/apache/activemq/pull/1728 --> async send proposal. Willing to get feedback because it's a production change to support async send for JMS 3.1 which I can pass with it. They are all green, so I'd appraciate some help to review them. -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com
