Hi Everyone, I wanted to start a discussion for working on shared subscription support after Matt pushed some initial work to https://github.com/apache/activemq/pull/2225. I commented on that PR with the same info but after that I realized it should really be here as a dev discussion
I think the best approach is to create a long running feature branch (doesn't matter what it is called). Shared subscription support is going to take a lot of work and needs to be done in several steps. By isolating the work into a separate branch we can create lots of PRs to split up the work without having to worry about breaking the build which is going to happen. There's a lot of changes so it might take a few iterations until we are happy with it. With a separate branch we can also avoid having to worry about keeping existing things working with transition or temporary classes to isolate things. After creating the branch we need to periodically merge the main branch into it (note I said merge, we don't want to rebase) to keep things up to date. Once we think it's good we can create a PR and merge the feature branch back into main and preserve the commit history. So the basic flow would be: 1. Create a feature branch for shared sub support in the activemq repo 2. periodically merge main into it to keep it up to date and resolve conflicts 3. create PRs against the feature branch 4. Merge the feature branch back into main when we are done Chris --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
