audiBookning commented on issue #56: URL: https://github.com/apache/incubator-age/issues/56#issuecomment-827791242
As for conventions about case-insensitive or not, i don't really have an opinion. i think the most important is for them to be clear and for everybody following them. Databases is not really my cup of tea and i am not familiar with this repo's code or even writing postgresql extension, so my following comments are very "tentative". I am preoccupied that case-insensitivity in Labels might have some performance impact on the extension in some extreme cases. Labels in AGE are stored as a record in a table ag_label of the ag_catalog schema. And since searching records is case-sensitive, the code would have to make a full table search with LOWER or UPPER (and also possibly the two at the same time because, quoting another person, "some characters have different representations in upper case but the same representation in lower case") every time to detect possible duplicates? To avoid this, the code could forcibly transform them to LOWER (for example) upon creation. But there might have more complications... It seems that there is some kind of cache, but it is another thing where i am not sure of the implications. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
