emotionbug opened a new issue #85:
URL: https://github.com/apache/incubator-age/issues/85
when use make with -j option like `make -j16` throws error with
`cypher_gram_def.h`
```
src/backend/parser/cypher_gram.c:147:10: fatal error: cypher_gram_def.h: no
such file or directory
147 | #include "cypher_gram_def.h"
| ^~~~~~~~~~~~~~~~~~~
```
it seems trying to compile, before bison generate codes.
so, how about change `Makefile` like behind?
PS, looks like bison not generating with directory part prefix after Bison
3.7.
so, I added `CPPFLAGS` for include header without prefix.
`PG_CPPFLAGS = -I$(ag_include_dir) -I$(ag_include_dir)/parser`
I don't think this is a good way. therefore, how about giving options
according to the version.
`Directive: %define api.header.include {"header.h"}`
https://www.gnu.org/software/bison/manual/html_node/_0025define-Summary.html
```diff
74c74
< cypher_delete \
---
> cypher_delete \
82c82
< EXTRA_CLEAN = $(addprefix $(ag_regress_dir)/, $(ag_regress_out))
---
> EXTRA_CLEAN = $(addprefix $(ag_regress_dir)/, $(ag_regress_out))
src/backend/parser/cypher_gram.c src/include/parser/cypher_gram_def.h
85c85
< PG_CPPFLAGS = -I$(ag_include_dir)
---
> PG_CPPFLAGS = -I$(ag_include_dir) -I$(ag_include_dir)/parser
91c91,96
< src/backend/parser/cypher_gram.c: BISONFLAGS +=
--defines=$(ag_include_dir)/parser/$(basename $(notdir $@))_def.h
---
> src/include/parser/cypher_gram_def.h: src/backend/parser/cypher_gram.c
>
> src/backend/parser/cypher_gram.c: BISONFLAGS +=
--defines=src/include/parser/cypher_gram_def.h
>
> src/backend/parser/cypher_parser.o: src/backend/parser/cypher_gram.c
> src/backend/parser/cypher_keywords.o: src/backend/parser/cypher_gram.c
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
