Hi Raman, On Tue, Oct 2, 2012 at 2:05 PM, Raminderjeet Singh <[email protected] > wrote:
> It need to be AiravataRegistry3 then :). We started airavata with > Xregistry. This is wrong, we do not have any release with XRegistry, it was just dumped from ogce version to Airavata so its is exactly AiravataRegistry2. Lahiru > These number my make sense to you but not to new developer. According to > me names should be based on Actions, capabilities using proper adjectives. > > -1 for AiravataRegistry2 and -1 for AiravataRegistryblahblah > > Thanks > Raman > > On Oct 2, 2012, at 1:52 PM, Lahiru Gunathilake wrote: > > > Hi Raman, > > > > Thanks for pointing this out. I agree we need to add more test cases, but > > we were doing drastic changes in a very short time and I am glad we > didn't > > write much tests for previous code. > > > > I hope we need to start writing tests for this implementation and I > believe > > this one is much stable than the previous registry implementation. > > > > Regarding the AiravataRegistry we cannot put a meaningful name because > its > > a very very abstract interface.. whoever implement it has to have a nice > > name for that. I personally +1 for AiravataRegistry2 and its nice for me > > because its basically the second Registry implementation of Airavata we > > have implemented. > > > > So here's my +1 for AiravataRegistry2 ! > > > > Lahiru > > > > On Tue, Oct 2, 2012 at 1:40 PM, Marlon Pierce <[email protected]> wrote: > > > >> -----BEGIN PGP SIGNED MESSAGE----- > >> Hash: SHA1 > >> > >> And don't forget the Sonar dashboard: > >> https://analysis.apache.org/dashboard/index/79319 > >> > >> > >> Marlon > >> > >> > >> On 10/2/12 1:39 PM, Amila Jayasekara wrote: > >>> +1 for both ideas. Unit tests are important specifically when we > >>> are refactoring code. That helps us to confidently change code and > >>> make sure nothing is broken. > >>> > >>> Thanks Amila > >>> > >>> On Tue, Oct 2, 2012 at 1:30 PM, Raminderjeet Singh > >>> <[email protected]> wrote: > >>>> Hi Dev, > >>>> > >>>> I have seen some bad naming conventions followed in Registry API > >>>> like AiravataRegisty1 and AiravataRegisty2 etc. This is user > >>>> interaction interface for Airavata and we need to use meaningful > >>>> names. Lets spend a min or 2 while naming a class or interface as > >>>> it will take more time if you or someone else need to do it > >>>> later. Java coding conversions [1] need to be followed for rest > >>>> of the project. > >>>> > >>>> Another important thing we need to improve is unit tests > >>>> specially for AiravataAPI to start with. Currently we don't have > >>>> any unit test cases for Airavata API (JCRRegistryTest was there > >>>> which i am removing to address Airavata-589). > >>>> > >>>> Thanks Raminder > >>>> > >>>> > >>>> 1. > >>>> > >> > http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html > >> -----BEGIN PGP SIGNATURE----- > >> Version: GnuPG/MacGPG2 v2.0.16 (Darwin) > >> Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ > >> > >> iQEcBAEBAgAGBQJQaycfAAoJEOEgD2XReDo5hpEH/jj9FT0oE+0xUYF/dknw5IZO > >> CqCSd9mQl1Iu4TTqOciMFo93h4p4l1PPg2TNc6SzlLurn5GXmCFZvkizER08pAfF > >> r78HCMvSqDbVYWznge5RG6TwAebWw8x1sVIF4eVUcgzjkXWgRydlA5Ln4wD2cyjK > >> QRMvPaQbVFoZv0iM0D0+ahK4REnu9TXaN43pU9o+9RARwiyNhz50535jKVI8Emdc > >> BBtyJhfvhrJ+q1HjnMno/wosz7LH2WRTSWCKRpUWZtlJRBcE7U1Sfw74qCZfU3Qd > >> 8uu4lMcYIIXJOHGK38+EVdscDS0X3uvBRSw7bch5modqS7cEFERNDBAywK8LZQU= > >> =2d4s > >> -----END PGP SIGNATURE----- > >> > > > > > > > > -- > > System Analyst Programmer > > PTI Lab > > Indiana University > > -- System Analyst Programmer PTI Lab Indiana University
