+ 1 for a API review. How about we do it before we carve out the 0.6 release? Just throwing a date, how about a google hangout on Monday and post back the summary of the discussion to the mailing list?
Suresh On Dec 7, 2012, at 1:32 PM, Saminda Wijeratne <[email protected]> wrote: > Lahiru/Raminder, > > Can we also have a small review on the WorkflowManager while we are at > this? If you can look at the existing API methods and give your feedback on > how they can be improved on a developer perspective, the API will be more > stable based on requirements. > > Saminda > > On Fri, Dec 7, 2012 at 10:13 AM, Lahiru Gunathilake <[email protected]>wrote: > >> Yes I am +1 for this, but we need to change the workflow xml before sending >> it to backend.. >> >> I will add this method to API.. as saveWorkflowWithName. >> >> Lahiru >> >> On Fri, Dec 7, 2012 at 10:03 AM, Raminderjeet Singh < >> [email protected]> wrote: >> >>> As the Workflow XML is difficult to edit or user can make mistakes. Can >> we >>> have a API method to provide workflow name on upload? We can handle >>> updating the workflowName tag in XML programmatically in that method. >>> >>> Thanks >>> Raminder >>> On Dec 7, 2012, at 9:56 AM, Lahiru Gunathilake wrote: >>> >>>> FYI, We are saving the workflow with the name in the workflow (workflow >>>> file has an element called workflowName). I will put some comments on >> the >>>> API and we should put some note on API docs too. >>>> >>>> Regards >>>> Lahiru >>>> >>>> On Thu, Dec 6, 2012 at 4:44 PM, Lahiru Gunathilake <[email protected] >>>> wrote: >>>> >>>>> Hi Devs, >>>>> >>>>> While I was working on some samples I realize saveWorkflow methods are >>> not >>>>> allowing users to give their own worklfow name or atleast its not >>> returning >>>>> workflow saved names. >>>>> >>>>> When we use the API we need to have the workflow name which got saved >> in >>>>> to registry. >>>>> >>>>> I think we should return workflow name as the return value of >>> saveWorkflow >>>>> methods and we need to provide another method to give user given >>> workflow >>>>> name to be provided. >>>>> >>>>> Please correct me if I am wrong. >>>>> >>>>> >>>>> Regards >>>>> Lahiru >>>>> >>>>> -- >>>>> System Analyst Programmer >>>>> PTI Lab >>>>> Indiana University >>>>> >>>>> >>>> >>>> >>>> -- >>>> System Analyst Programmer >>>> PTI Lab >>>> Indiana University >>> >>> >> >> >> -- >> System Analyst Programmer >> PTI Lab >> Indiana University >>
