Hi Dev,

Was this provider tested before? I identified few problems related to design 
and functioning of SSHProvider and would like to discuss before fixing them in 
trunk.  

Class : org.apache.airavata.core.gfac.provider.impl.SSHProvider

1.SSHProvider is not getting called in SchedulerImpl. Else condition is default 
to GramProvider (AIRAVATA-747). I can add a check of some type but ideally 
schema should provide the type.
2.sshj-0.5.0.jar is not copied in airavata distribution ( AIRAVATA-748). I will 
change the maven build to fix this.
3. getSession method have authPublickey called before creating connection. 
Fixed by fixing the method calls. (AIRAVATA-751)
4.We are creating wrong ssh command [1] to execute.  We are expecting that ssh 
run should create stdout and stderr files on remote machine but according to 
command these files are going to be created locally where airavata server is 
running. Its easy to fix the paths but i want to get idea about the design. 
(AIRAVATA-752)


4th need discussion as this can be solved in different ways. In the previous 
version of GFAC [2], we had a method createShellScript() to wrap all the 
commands in a shell script and transfer that script before calling it in the 
execute method. Advantages of previous approach were, 1. it was easy to set 
system variable on remote machine before executing the application executable 
using wrapper shell script, 2. Set input, output variables for remote 
application to read to create output. 3. stdout/error file path can be remote.  
In the new API there is a method to set environment session.setEnvVar [3] but 
its not working. 


Do you think we should create a local directory for stdout and error? Please 
evaluate both the approaches looking at the code and give your input.  

Thanks
Raminder


1. ssh gw85.iu.xsede.org /bin/echo aa  1> 
/tmp/echo_gw85_Tue_Jan_29_14_04_54_EST_2013_941029ce-f3b6-4cd3-acaa-f8b2a26b553a/GW85_application.stdout
 2> 
/tmp/echo_gw85_Tue_Jan_29_14_04_54_EST_2013_941029ce-f3b6-4cd3-acaa-f8b2a26b553a/GW85_application.stderr
-bash: 
/tmp/echo_gw85_Tue_Jan_29_14_04_54_EST_2013_941029ce-f3b6-4cd3-acaa-f8b2a26b553a/GW85_application.stdout:
 No such file or directory
2. 
https://ogce.svn.sourceforge.net/svnroot/ogce/gateway-staging/DES/gfac/src/edu/indiana/extreme/gfac/provider/SshProvider.java
3. 
https://svn.apache.org/repos/asf/airavata/trunk/modules/gfac-core/src/main/java/org/apache/airavata/core/gfac/provider/impl/SSHProvider.java


Reply via email to