Hi Amila, Yes I agree ! Lets fix it and read files from a given location and lets make sure it works on Tomcat too.
Lahiru On Fri, Mar 8, 2013 at 11:26 AM, Amila Jayasekara <[email protected]>wrote: > On Fri, Mar 8, 2013 at 10:09 AM, Lahiru Gunathilake <[email protected]> > wrote: > > Hi Danushka, > > > > We normally read files from the classpath in code, so I tried to add each > > file in to classpath in airavata-server.sh and file loading didn't work > > when i put the configuration files there. > > > > WhateverClass.class.getClassLoader().getResource("filename") > > > > I am +1 to fix this issue, but unless we read files like this, there > could > > be issues when we deploy airavata on tomcat as set of services on axis2 > > webapp. > > Reading configuration files using class loader is sometimes very > confusing. Cos it depends on the class loading order. I am +1 to read > configurations from a proper file system location. Further we should > have a single module to read all configurations. Any component that > needs configurations should go through above mentioned module to read > configurations. (Currently we have several places where we read > configurations - It sort of also duplicate the code). > > Thanks > Amila > > > > > Regards > > Lahiru > > > > > > > > On Sun, Feb 24, 2013 at 3:36 AM, Danushka Menikkumbura < > > [email protected]> wrote: > > > >> Hi Suresh, > >> > >> I see them in both server and client. > >> > >> server - airavata-server.properties, authenticators.xml, > gfac-config.xml, > >> log4j.properties, host.xml and axis2.xml > >> client - airavata-client.properties and log4j.properties > >> > >> Thanks, > >> Danushka > >> > >> > >> On Sun, Feb 24, 2013 at 8:39 AM, Suresh Marru <[email protected]> > wrote: > >> > >> > Hi Danushka, > >> > > >> > Which distribution are you referring to? server, client, xbaya? > >> > > >> > Agreed they should be in conf. > >> > > >> > Suresh > >> > > >> > On Feb 23, 2013, at 7:50 PM, Danushka Menikkumbura < > >> > [email protected]> wrote: > >> > > >> > > Hi Devs, > >> > > > >> > > While fixing the Windows issue, I noticed that configuration files > also > >> > > reside in the bin directory of distribution packages. I think they > >> should > >> > > be a conf directory for configuration files so that the bin > directory > >> > will > >> > > not get cluttered. > >> > > > >> > > Thanks, > >> > > Danushka > >> > > >> > > >> > > > > > > > > -- > > System Analyst Programmer > > PTI Lab > > Indiana University > -- System Analyst Programmer PTI Lab Indiana University
