----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15789/#review29605 -----------------------------------------------------------
https://svn.apache.org/repos/asf/airavata/trunk/modules/rest/service/src/main/java/org/apache/airavata/services/registry/rest/resources/CredentialRegistryResource.java <https://reviews.apache.org/r/15789/#comment57007> Username is the token id in the case of IU gateway. But i will change this to be more generic https://svn.apache.org/repos/asf/airavata/trunk/modules/airavata-client/src/main/java/org/apache/airavata/client/api/CredentialStoreManager.java <https://reviews.apache.org/r/15789/#comment57006> This method would actually just return the public key of the credential. Since it is the public key, there should be no harm in retrieving it through the API. I cant think of an usecase right now where this might be used but since this is a generic API, i thought we needed to add this functionality. Maybe i can rename the method to be more specific. But it is not needed, then i can remove it. https://svn.apache.org/repos/asf/airavata/trunk/modules/airavata-client/src/main/java/org/apache/airavata/client/api/CredentialStoreManager.java <https://reviews.apache.org/r/15789/#comment57004> persistCredentials would have been appropriate if we are actually passing in a credential and saving a credential. In this case, based on the gatewayid and token we are creating a SSH Keypair and then storing it. That's is why i named it so - Viknes Balasubramanee On Nov. 22, 2013, 2:43 p.m., Viknes Balasubramanee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15789/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2013, 2:43 p.m.) > > > Review request for Airavata. > > > Bugs: Airavata-952 > https://issues.apache.org/jira/browse/Airavata-952 > > > Repository: Airavata > > > Description > ------- > > Add credential store functionalities to the Airavata API > > > Diffs > ----- > > > https://svn.apache.org/repos/asf/airavata/trunk/modules/airavata-client/src/main/java/org/apache/airavata/client/AiravataClient.java > 1541741 > > https://svn.apache.org/repos/asf/airavata/trunk/modules/airavata-client/src/main/java/org/apache/airavata/client/api/AiravataAPI.java > 1541741 > > https://svn.apache.org/repos/asf/airavata/trunk/modules/airavata-client/src/main/java/org/apache/airavata/client/api/CredentialStoreManager.java > PRE-CREATION > > https://svn.apache.org/repos/asf/airavata/trunk/modules/airavata-client/src/main/java/org/apache/airavata/client/impl/CredentialStoreManagerImpl.java > PRE-CREATION > > https://svn.apache.org/repos/asf/airavata/trunk/modules/credential-store/pom.xml > 1541741 > > https://svn.apache.org/repos/asf/airavata/trunk/modules/credential-store/src/main/java/org/apache/airavata/credential/store/credential/impl/ssh/SSHCredential.java > PRE-CREATION > > https://svn.apache.org/repos/asf/airavata/trunk/modules/credential-store/src/main/java/org/apache/airavata/credential/store/credential/impl/ssh/SSHCredentialGenerator.java > PRE-CREATION > > https://svn.apache.org/repos/asf/airavata/trunk/modules/credential-store/src/main/java/org/apache/airavata/credential/store/store/impl/SSHCredentialWriter.java > PRE-CREATION > > https://svn.apache.org/repos/asf/airavata/trunk/modules/credential-store/src/main/java/org/apache/airavata/credential/store/store/impl/db/CredentialsDAO.java > 1541741 > > https://svn.apache.org/repos/asf/airavata/trunk/modules/registry/airavata-jpa-registry/pom.xml > 1541741 > > https://svn.apache.org/repos/asf/airavata/trunk/modules/registry/airavata-jpa-registry/src/main/java/org/apache/airavata/persistance/registry/jpa/impl/AiravataJPARegistry.java > 1541741 > > https://svn.apache.org/repos/asf/airavata/trunk/modules/registry/registry-api/src/main/java/org/apache/airavata/registry/api/AiravataRegistry2.java > 1541741 > > https://svn.apache.org/repos/asf/airavata/trunk/modules/registry/registry-api/src/main/java/org/apache/airavata/registry/api/CredentialRegistry.java > PRE-CREATION > > https://svn.apache.org/repos/asf/airavata/trunk/modules/rest/client/src/main/java/org/apache/airavata/rest/client/CredentialStoreResourceClient.java > PRE-CREATION > > https://svn.apache.org/repos/asf/airavata/trunk/modules/rest/client/src/main/java/org/apache/airavata/rest/client/RegistryClient.java > 1541741 > > https://svn.apache.org/repos/asf/airavata/trunk/modules/rest/mappings/src/main/java/org/apache/airavata/rest/mappings/utils/ResourcePathConstants.java > 1541741 > > https://svn.apache.org/repos/asf/airavata/trunk/modules/rest/service/src/main/java/org/apache/airavata/services/registry/rest/resources/CredentialRegistryResource.java > PRE-CREATION > > https://svn.apache.org/repos/asf/airavata/trunk/modules/rest/service/src/main/java/org/apache/airavata/services/registry/rest/resources/UserRegistryResource.java > 1541741 > > Diff: https://reviews.apache.org/r/15789/diff/ > > > Testing > ------- > > > Thanks, > > Viknes Balasubramanee > >
