[
https://issues.apache.org/jira/browse/AIRAVATA-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847636#comment-13847636
]
Chathuri Wimalasena commented on AIRAVATA-963:
----------------------------------------------
Hi Sachith,
There are few problems with the patch. Integration tests were not passing when
run a build after applying the patch. I saw some problems with the
WorkflowIntegrationTestBase class.
1. In methods, addHostDescriptor(), addServiceDescriptor(),
addApplicationDescriptor(), before adding the descriptors you are trying to get
the descriptor. Instead of that, you can check isDescriptorExists method
instead of getting that object.
2. In method addHostDescriptor(), you do not need to get all the host
descriptors and check for equality of the xml file. Since host descriptor is
unique for a gateway, you can just use the same isHostDescriptorExists method.
Another problem is in the BaseCaseIT class. In there also, instead of getting
the workflow object, you can check whether workflow exists method.
I committed the patch with some of the improvements. You can work on other
improvements and submit another patch.
> Refactoring Integration Tests module to allow easy extendability and remove
> redundancy
> --------------------------------------------------------------------------------------
>
> Key: AIRAVATA-963
> URL: https://issues.apache.org/jira/browse/AIRAVATA-963
> Project: Airavata
> Issue Type: Improvement
> Reporter: Sachith Withana
> Priority: Minor
> Attachments: integration_tests_refactor-2.patch,
> integration_tests_refactor.patch, integration_tests_refactor_update3.patch
>
>
> I noticed the integration tests contain redundant code. Redundant code should
> be removed and allow easy extendable integration tests.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
