Hi Suresh, Here are couple of examples I had about using a script to generate code for Thrift
http://git-wip-us.apache.org/repos/asf/accumulo.git You can find the code generation script under core/src/main/scripts Another simple project is https://github.com/yahoo/storm-yarn Hadoop is using prtotocol buffers and they require protocol buffers to be installed in the system to compile hadoop. May be Hadoop can afford to do that :) Thanks, Supun.. On Tue, Feb 4, 2014 at 11:36 AM, Suresh Marru <[email protected]> wrote: > Thanks Supun. Do you have any good references of public repos which you > liked the thrift organization? I am trying to follow how cassandra is doing > it. We also need to worry about license headers to the generated code to > pass the release checks. > > Suresh > > On Feb 4, 2014, at 11:28 AM, Supun Kamburugamuva <[email protected]> > wrote: > > > I think the general practice in Thrift is to include a script that can > do the thrift source generation if it needs to be done. The generated code > is committed to the source repo. > > > > You can also use the maven plugin along with a maven profile to generate > the code, if code generation is required. > > > > Thanks, > > Supun.. > > > > > > On Tue, Feb 4, 2014 at 11:21 AM, Suresh Marru <[email protected]> wrote: > > Frankly we need some first hand experience and keep iterating on > approaches on how all of this will play out across versions. Lets start > with some approach and go from there. > > > > Thrift has a maven plugin in development but Chathuri confirmed even it > will need thrift to be installed locally. It makes sense since the thrift > generator is in C++ and is platform dependent. > > > > Suresh > > > > On Feb 4, 2014, at 11:13 AM, Lahiru Gunathilake <[email protected]> > wrote: > > > > > Hi Suresh, > > > > > > Does thrift has a maven plugin to generate classes ? We can have > interfaces in one module and different implementations in a separate > module. If there's a change (API level change, the implementation modules > should be changed, otherwise they shouldn't be compiled). But if someone > wants the old one they can have a dependency to the old module and should > be able to compile the impl module). > > > > > > Suresh, WDYT ? > > > > > > Regards > > > Lahiru > > > > > > > > > On Tue, Feb 4, 2014 at 11:10 AM, Suresh Marru <[email protected]> > wrote: > > > On Feb 4, 2014, at 9:59 AM, Lahiru Gunathilake <[email protected]> > wrote: > > > > > > > Hi Suresh, > > > > > > > > Current airavataAPI looks very clean and easy to understand. Thanks > to your very detail comments I was able to understand the process. > > > > > > > > I think we need to make sure we give a simple easy to use > experimentModel.ConfigurationData object to configure. What is our plan > with implementing experimentModel.ConfigurationData ? > > > > > > Yes, we need every one's critical eye in making these configuration > data to cover all the use cases, yet be simple and as concise as possible. > > > > > > For the implementation, thrift has a generator for java beans (in > addition to standard java) which essentially makes all members to private > with setters to return void. We can have this generated beans as a separate > airavata-thrift-datamodel.jar and all components will use this the same way > we now use workflow execution context or workflow tracking library. Not > sure if this is what you asked. > > > > > > > Regards > > > > Lahiru > > > > > > > > > > > > On Tue, Feb 4, 2014 at 9:35 AM, Marlon Pierce <[email protected]> > wrote: > > > > Where do these go? In modules/thrift-interfaces? > > > > > > I am now poking around at other thrift based projects to find a way to > organize these. A challenge I see if how to over-write the generated > classes without loosing any implementations. Will post a layout for > discussion soon. > > > > > > Suresh > > > > > > > > > > > > > > Marlon > > > > > > > > On 2/4/14 9:34 AM, Suresh Marru wrote: > > > > > Makes sense Lahiru. I will commit generated data model into > commons and client stubs and server skeletons. > > > > > > > > > > Suresh > > > > > > > > > > On Feb 4, 2014, at 9:18 AM, Lahiru Gunathilake <[email protected]> > wrote: > > > > > > > > > >> Hi Suresh, > > > > >> > > > > >> I think to do a proper review, we need to generate code and > commit to the repository. This will make life easier for developers, > because everybody doesn't have to go through the hard steps to install > Thrift in their machines. > > > > >> > > > > >> By looking in to .thrift files its difficult to navigate through > the object model and hard to understand it. > > > > >> > > > > >> Regards > > > > >> Lahiru > > > > >> > > > > >> > > > > >> On Mon, Feb 3, 2014 at 1:04 PM, Marlon Pierce <[email protected]> > wrote: > > > > >> Hangout URL is > > > > >> > https://plus.google.com/hangouts/_/72cpjvt6sl94fnn4hs10bibi6g?hl=en > > > > >> > > > > >> > > > > >> Marlon > > > > >> > > > > >> On 2/3/14 9:14 AM, Marlon Pierce wrote: > > > > >>> Hi all-- > > > > >>> > > > > >>> We'll have a hangout at 1:00 pm US EST to discuss the subject. > Hangout > > > > >>> URL will be forthcoming. > > > > >>> > > > > >>> > > > > >>> Marlon > > > > >>> > > > > >> > > > > >> > > > > >> > > > > >> -- > > > > >> System Analyst Programmer > > > > >> PTI Lab > > > > >> Indiana University > > > > > > > > > > > > > > > > > > > > -- > > > > System Analyst Programmer > > > > PTI Lab > > > > Indiana University > > > > > > > > > > > > > > > -- > > > System Analyst Programmer > > > PTI Lab > > > Indiana University > > > > > > > > > > -- > > Supun Kamburugamuva > > Member, Apache Software Foundation; http://www.apache.org > > E-mail: [email protected]; Mobile: +1 812 369 6762 > > Blog: http://supunk.blogspot.com > > > > -- Supun Kamburugamuva Member, Apache Software Foundation; http://www.apache.org E-mail: [email protected]; Mobile: +1 812 369 6762 Blog: http://supunk.blogspot.com
