[ 
https://issues.apache.org/jira/browse/AIRAVATA-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gagan Deep Juneja updated AIRAVATA-1283:
----------------------------------------

    Attachment: 0001-AIRAVATA-1283-Added-support-for-hostname-in-all-serv.patch

Hi Team,
I have made code changes to fix this issue. I also moved some code here and 
there for refactoring purpose. I am new and not sure what process is being 
followed in Airavata Project for patch review. So I am attaching the patch here 
for review.
I did not test this because I dont have ready setup with me. Request you to 
test for sanity scenarios once although tests are passing in build.

Please do let me know your feedback.

Regards,
Gagan

> local host is hard coded in all the thrift clients 
> ---------------------------------------------------
>
>                 Key: AIRAVATA-1283
>                 URL: https://issues.apache.org/jira/browse/AIRAVATA-1283
>             Project: Airavata
>          Issue Type: Bug
>          Components: Airavata Client, Airavata Orchestrator
>    Affects Versions: 0.12
>         Environment: mac
>            Reporter: Lahiru Gunathilake
>             Fix For: 0.12
>
>         Attachments: 
> 0001-AIRAVATA-1283-Added-support-for-hostname-in-all-serv.patch
>
>
> In all the places each thrift client is hard coded with host and some places 
> with port too. In this case even though these are different thirft services 
> these cannot be hosted in two different machines.
> I think this is a bad practice and unnecessary limitation. Ideally we should 
> read the ip from ip property and ports should be configurable.
> any thrift service can be removed from airavata by removing server list in 
> airavata-server.properties.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to