[
https://issues.apache.org/jira/browse/AIRAVATA-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14027878#comment-14027878
]
Lahiru Gunathilake commented on AIRAVATA-1283:
----------------------------------------------
HI Gagan,
Thanks for submitting a patch. But when I try to apply the patch I get
following error and patch cannot be applied to latest trunk.
git am --signoff <
0001-AIRAVATA-1283-Added-support-for-hostname-in-all-serv.patch
Applying: AIRAVATA-1283 - Added support for hostname in all servers.
/Users/lahirugunathilake/Desktop/airavata/.git/rebase-apply/patch:34: trailing
whitespace.
/Users/lahirugunathilake/Desktop/airavata/.git/rebase-apply/patch:36: trailing
whitespace.
/Users/lahirugunathilake/Desktop/airavata/.git/rebase-apply/patch:43: trailing
whitespace.
/Users/lahirugunathilake/Desktop/airavata/.git/rebase-apply/patch:66: trailing
whitespace.
/Users/lahirugunathilake/Desktop/airavata/.git/rebase-apply/patch:68: trailing
whitespace.
warning: squelched 5 whitespace errors
warning: 10 lines add whitespace errors.
I tried with git apply command too and it gave me following error. Can you try
applying your patch to another clone in your own machine and send the patch.
git apply 0001-AIRAVATA-1283-Added-support-for-hostname-in-all-serv.patch
0001-AIRAVATA-1283-Added-support-for-hostname-in-all-serv.patch:39: trailing
whitespace.
0001-AIRAVATA-1283-Added-support-for-hostname-in-all-serv.patch:41: trailing
whitespace.
0001-AIRAVATA-1283-Added-support-for-hostname-in-all-serv.patch:48: trailing
whitespace.
0001-AIRAVATA-1283-Added-support-for-hostname-in-all-serv.patch:71: trailing
whitespace.
0001-AIRAVATA-1283-Added-support-for-hostname-in-all-serv.patch:73: trailing
whitespace.
error: patch failed:
airavata-api/airavata-api-server/src/main/java/org/apache/airavata/api/server/AiravataAPIServer.java:21
error:
airavata-api/airavata-api-server/src/main/java/org/apache/airavata/api/server/AiravataAPIServer.java:
patch does not apply
error: patch failed:
airavata-api/airavata-api-server/src/main/java/org/apache/airavata/api/server/ApplicationCatalogServer.java:21
error:
airavata-api/airavata-api-server/src/main/java/org/apache/airavata/api/server/ApplicationCatalogServer.java:
patch does not apply
error: patch failed:
airavata-api/airavata-api-server/src/main/java/org/apache/airavata/api/server/handler/AiravataServerHandler.java:23
error:
airavata-api/airavata-api-server/src/main/java/org/apache/airavata/api/server/handler/AiravataServerHandler.java:
patch does not apply
error: patch failed:
airavata-api/airavata-api-server/src/main/java/org/apache/airavata/api/server/util/Constants.java:22
error:
airavata-api/airavata-api-server/src/main/java/org/apache/airavata/api/server/util/Constants.java:
patch does not apply
error: patch failed:
modules/configuration/server/src/main/resources/airavata-server.properties:315
error:
modules/configuration/server/src/main/resources/airavata-server.properties:
patch does not apply
error: modules/orchestrator/NULL: already exists in working directory
error: patch failed:
modules/orchestrator/airavata-orchestrator-service/src/main/java/org/apache/airavata/orchestrator/server/OrchestratorServer.java:21
error:
modules/orchestrator/airavata-orchestrator-service/src/main/java/org/apache/airavata/orchestrator/server/OrchestratorServer.java:
patch does not apply
error: patch failed:
modules/orchestrator/airavata-orchestrator-service/src/main/java/org/apache/airavata/orchestrator/util/Constants.java:23
error:
modules/orchestrator/airavata-orchestrator-service/src/main/java/org/apache/airavata/orchestrator/util/Constants.java:
patch does not apply
> local host is hard coded in all the thrift clients
> ---------------------------------------------------
>
> Key: AIRAVATA-1283
> URL: https://issues.apache.org/jira/browse/AIRAVATA-1283
> Project: Airavata
> Issue Type: Bug
> Components: Airavata Client, Airavata Orchestrator
> Affects Versions: 0.12
> Environment: mac
> Reporter: Lahiru Gunathilake
> Fix For: 0.12
>
> Attachments:
> 0001-AIRAVATA-1283-Added-support-for-hostname-in-all-serv.patch
>
>
> In all the places each thrift client is hard coded with host and some places
> with port too. In this case even though these are different thirft services
> these cannot be hosted in two different machines.
> I think this is a bad practice and unnecessary limitation. Ideally we should
> read the ip from ip property and ports should be configurable.
> any thrift service can be removed from airavata by removing server list in
> airavata-server.properties.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
