Hi Shameera, I think it always good create minimum layers with docker images do you mean concatenating multiple RUN statements together?
"COPY ./ /var/www/airavata-php-gateway" is copying the content of the php gateway(/var/www/airavata-php-gateway) from local host system to the docker image. MAINTAINER to "Apache Airavata Community" Yes I will change it to appropriate. Other docker file is also available here attached (this is also uploaded to pankajsaha/dockerfiles git registry) Thanks pankaj On Wed, Jul 22, 2015 at 10:24 AM, Shameera Rathnayaka < [email protected]> wrote: > Hi Pankaj, > > I think it always good create minimum layers with docker images, because > it is required to download large number of layers when you push this to > registry. base on that I would suggest to create one layer for all > prerequisites and one layer for all php extensions. e.g.: RUN apt-get > install -y apache2 php5 > > What are the things you copy here "COPY ./ /var/www/airavata-php-gateway" > ? > #--------- modifying the 000default file section without copy command, > can be reduced to one layer. > > If you going to contribute this to Apache, you may need to change > MAINTAINER to "Apache Airavata Community" > > BTW what about other docker files? > > Thanks, > Shameera > > On Tue, Jul 21, 2015 at 12:21 PM Pankaj Saha <[email protected]> > wrote: > >> Hi Lahiru/shameera, >> >> Can you please once again review the docker file for airavata pga and >> send your comments.They are available at github: >> https://github.com/pankajsaha/dockerfiles. Dockerfile should be present >> at the root of the airavata-php-gateway source tree structure. >> >> also you can see it here at attachment. >> >> Thanks >> Pankaj >> >> >> -- > Shameera Rathnayaka >
#---------- set the base image to Ubuntu FROM ubuntu #---------- file Author / Maintainer MAINTAINER Apache Airavata Community #---------- update the repository sources list RUN apt-get update #---------- installing jdk8 RUN apt-get install wget -y RUN wget --header "Cookie: oraclelicense=accept-securebackup-cookie" http://download.oracle.com/otn-pub/java/jdk/8u5-b13/jdk-8u5-linux-x64.tar.gz RUN mkdir opt/jdk RUN tar -zxf jdk-8u5-linux-x64.tar.gz -C opt/jdk RUN update-alternatives --install /usr/bin/java java /opt/jdk/jdk1.8.0_05/bin/java 100 RUN update-alternatives --install /usr/bin/javac javac /opt/jdk/jdk1.8.0_05/bin/javac 100 #-------- adding server executable code ADD ./modules/distribution/server/target/apache-airavata-server-0.15-SNAPSHOT /apache-airavata-server-SNAPSHOT WORKDIR /apache-airavata-server-SNAPSHOT/bin #--------- starting the airavata service #CMD bash -C 'sh airavata-server.sh start';'bash' #--------- exposing port EXPOSE 8930
