Hi Abhijit, I merged your pull request.
Few things, 1. I changed the name of the module from user-profile-cpi to user-profile-stubs 2. Please update the help section in the cpi thrift generation script to include the new command to generate user profile cpi. 3. Instead of RegistryServiceException please use a different exception (e.g UserProfileException) in the UserProfileService. On Tue, Nov 8, 2016 at 5:20 PM, Abhijit Karanjkar < [email protected]> wrote: > Hi Supun/Anuj, > As discussed with Supun earlier, I have changed the location of user > profile cpi files in "generate_cpi_stub.sh" so that the class files will be > created > in "../../modules/user-profile/user-profile-cpi/src/main/java" whenever > we run the .sh file mentioned above. > > Please pull the latest code from registry-refactoring branch and try > running the file given above. Let me know if you face any issues. > > @Supun: Please correct me if I am wrong here. > > Regards, > Abhijit Karanjkar > > On Fri, Nov 4, 2016 at 12:00 PM, Abhijit Karanjkar < > [email protected]> wrote: > >> Hi Supun/Anuj >> I have added thrift file to generate User Profile CPI service under >> registry-refactoring branch. >> Could you please pull the changes and run generate_cpi_stub.sh? Let me >> know if it correctly generates the corresponding CPI files. >> >> Note: First Changes need to be merged to upstream, I have created a pull >> request. >> >> Thanks & regards, >> Abhijit Karanjkar >> > > -- Thank you Supun Nakandala Dept. Computer Science and Engineering University of Moratuwa
