machristie commented on a change in pull request #8: Python SDK for authentication was keycloak and for other admin services URL: https://github.com/apache/airavata-custos/pull/8#discussion_r325387999
########## File path: clients/python/airavata_custos/security/keycloak_connectors.py ########## @@ -0,0 +1,135 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +import time +from oauthlib.oauth2 import LegacyApplicationClient +from requests_oauthlib import OAuth2Session +import requests +from airavata_custos import settings + + +class KeycloakBackend(object): Review comment: There are two parts to the redirect flow: 1. Redirect to the IdP 2. Process the response You've implemented the second one. We could also have a utility code for generating the approach redirection URL for initiating the first part. In the Django portal, setting up the redirect URL is handled here: https://github.com/apache/airavata-django-portal/blob/master/django_airavata/apps/auth/views.py#L42 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
