Hi Gopi, Thanks for the PR.
I believe this is also related to others who are sending PRs to Airavata repos. Here are few tips on coding practices in order to contribute to Airavata I briefly went through your PR and I can see lots of junk files and unrelated file changes. I marked few of them and there are lot more in the PR. This is manly due to committing unrelated eclipse project files and doing code auto formatting inside the IDE. Different IDEs do different styles of formatting by default. Of course you can customize them but personally I would format them by hand whenever possible. It will improve your coding style. Whichever approach you follow, please have a look at git diff before committing. If you see unrelated changes like adding lots of tabs replacing space indentations inside the code, please revert them before committing. Always try to concentrate your changes regarding your main purpose of PR. For example. if you saw any bug in core or agent logic, raise them as separate PRs. Thanks Dimuthu On Tue, Apr 28, 2020 at 11:11 PM GOPI KIRAN <gopikiran...@gmail.com> wrote: > Hi Dimuthu, > > I have raised the PR for the FTP implementation. > Link: https://github.com/apache/airavata-mft/pull/12 > > With regards, > Gopi Kiran > > > On Tue, Apr 28, 2020 at 12:27 AM DImuthu Upeksha < > dimuthu.upeks...@gmail.com> wrote: > >> Awesome. Looking forward for your PR >> >> On Tue, Apr 28, 2020 at 12:07 AM GOPI KIRAN <gopikiran...@gmail.com> >> wrote: >> >>> I agree with you Dimuthu. >>> >>> I have written the implementation of FTP storage, resource, and secret >>> for all types (local DB, file) like it is written for Local and SCP >>> transport. >>> >>> I have finished the FTP implementation and will raise the PR by >>> tomorrow. If I need to implement the encryption part for the local DB, I >>> will implement it in the next PR. >>> >>> With regards, >>> Gopi Kiran >>> >>> >>> On Mon, Apr 27, 2020 at 11:47 PM DImuthu Upeksha < >>> dimuthu.upeks...@gmail.com> wrote: >>> >>>> Hi Gopi, >>>> >>>> This is implementation specific for secret backend type. If you are >>>> using the File Backend, you don't need to encrypt as it is the developer >>>> backend to test the framework so it needs to be simple as possible. But for >>>> production level backends, yes we should have them encrypted. >>>> >>>> Thanks >>>> Dimuthu >>>> >>>> On Mon, Apr 27, 2020 at 10:29 PM GOPI KIRAN <gopikiran...@gmail.com> >>>> wrote: >>>> >>>>> Hi, >>>>> >>>>> Since I need to use a password for FTP and since it's not an SFTP >>>>> password is the only method of authentication. Should I use Spring >>>>> security >>>>> tools like BCrypt to encrypt the passwords while storing it in local DB or >>>>> from the file? >>>>> >>>>> If that is okay then I would propose to do it with passphrase as well >>>>> for SCP transfer! >>>>> >>>>> With regards, >>>>> Gopi Kiran >>>>> >>>>
