machristie commented on a change in pull request #42:
URL:
https://github.com/apache/airavata-django-portal/pull/42#discussion_r441610153
##########
File path:
django_airavata/apps/admin/static/django_airavata_admin/src/components/gatewayprofile/StoragePreferenceList.vue
##########
@@ -177,6 +183,13 @@ export default {
}
return "...";
},
+ getUserStorageQuota(token) {
Review comment:
Maybe rename `token` to `quota` or `value`?
##########
File path:
django_airavata/apps/admin/static/django_airavata_admin/src/components/gatewayprofile/StoragePreferenceEditor.vue
##########
@@ -38,6 +41,21 @@ export default {
required: true
}
},
+ methods: {
+ handleTypedInput() {
+ const evt = window.event;
Review comment:
The event is passed as the first parameter to event handlers in Vue.
Please use that instead of `window.event` which is deprecated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
