machristie commented on a change in pull request #255:
URL: https://github.com/apache/airavata/pull/255#discussion_r441634972
##########
File path:
modules/registry/release-migration-scripts/next/DeltaScripts/appCatalog_schema_delta.sql
##########
@@ -24,3 +24,18 @@ use app_catalog;
alter table GROUP_COMPUTE_RESOURCE_PREFERENCE drop column IF EXISTS
RESERVATION;
alter table GROUP_COMPUTE_RESOURCE_PREFERENCE drop column IF EXISTS
RESERVATION_START_TIME;
alter table GROUP_COMPUTE_RESOURCE_PREFERENCE drop column IF EXISTS
RESERVATION_END_TIME;
+
+-- AIRAVATA-3343: Add UserStorageQuota entry to StoragePreferences table
+SET @AddUserStorageQuota = (SELECT IF(
Review comment:
This is good, but I think it would be more readable to use the `ALTER
TABLE <table name> ADD COLUMN IF NOT EXISTS` instead. I know that won't work
for ide-integration since it relies on a MySQL container, but I plan to update
that soon. But these release-migration-scripts we only run against MariaDB
databases where IF NOT EXISTS is supported.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
