Hi Eric, Thanks for the feedback. I updated the PR accordingly and managed to test it locally too.
Regards, Dinuka On Fri, Oct 23, 2020 at 1:50 AM Suresh Marru <[email protected]> wrote: > Thank you Eric, we will follow up on the PR. > > Suresh > > On Oct 22, 2020, at 4:13 PM, Franz, Eric <[email protected]> wrote: > > Suresh, > > I posted a comment here > https://github.com/apache/airavata/pull/265#issuecomment-714734200 > > And am happy to help however I can. > > Thanks, > Eric > > --- > Eric Franz, Gateways Lead Engineer > Ohio Supercomputer Center > An Ohio Technology Consortium (OH-TECH) Member > 1224 Kinnear Road > Columbus, OH 43212 > email: [email protected] > > *From: *Suresh Marru <[email protected]> > *Date: *Thursday, October 22, 2020 at 12:18 PM > *To: *Airavata Dev <[email protected]>, "Franz, Eric" < > [email protected]> > *Subject: *Re: [AIRAVATA-3379] airavata-ruby-sdk > > Hi Eric, > > Do you have suggestions on how ruby SDK’s should be distributed? Once > Dinuka packages thrift generated ruby libraries and adds some higher order > simplification API’s, can you please advise on what is the best practice > for creating a gem and publishing it to a gem repo? > > Thanks, > Suresh > > > On Oct 21, 2020, at 3:02 PM, Dinuka Desilva <[email protected]> > wrote: > > Hi Everyone, > > Following the other client sdks [1] available, I'm going to enable the > ruby sdk [2] for the airavata api. Meanwhile, I have a couple of points to > discuss. > > 1) Should we follow a similar pattern for additional code (apart from > what's generated from thrift) introduced to the clients regardless of > language? The feasibility is also one aspect to be discussed. > > 2) What's the process of publishing the clients to public registries? > > Regards, > Dinuka > > [1] > https://github.com/apache/airavata/tree/master/airavata-api/airavata-client-sdks > <https://urldefense.com/v3/__https:/github.com/apache/airavata/tree/master/airavata-api/airavata-client-sdks__;!!KGKeukY!kF3Lp5XEjGrUd3Mn1_MHMskmcOjmNBqg3n3lDCUX8Va4jJ8H3oowtrIcirtiPA$> > [2] https://github.com/apache/airavata/pull/265 > <https://urldefense.com/v3/__https:/github.com/apache/airavata/pull/265__;!!KGKeukY!kF3Lp5XEjGrUd3Mn1_MHMskmcOjmNBqg3n3lDCUX8Va4jJ8H3oowtrImbZefOQ$> > > >
