Hi Aishwarya, I echo it as well. Please do not wait for the code to be perfect, try to make it a habit to commit early and often to a PR. A big commit will delay reviews or demotivate reviews (due to lack of time), smaller and focused chucks make it faster.
Suresh > On Jul 1, 2022, at 1:56 PM, Aishwarya Sinhasane > <aishwaryasinhas...@gmail.com> wrote: > > Hii Dimuthu > > I will share document and code next week need some changes to do. > > Thanks and regards > Aishwarya Sinhasane > > On Fri, Jul 1, 2022, 1:27 PM DImuthu Upeksha <dimuthu.upeks...@gmail.com > <mailto:dimuthu.upeks...@gmail.com>> wrote: > Hi Aishwarya, > > This is a very solid improvement. Is there a way we can try these out? Do you > have a working fork? > > Thanks > Dimuthu > > On Fri, Jul 1, 2022 at 12:59 PM Pamidighantam, Sudhakar <pamid...@iu.edu > <mailto:pamid...@iu.edu>> wrote: > Aishwarya: > > > > Looks good. Keep this and then look at JS molecular Editors or third party > editors such as Avagadro, or Ovito. Let us plan to meet next week to look at > these and discuss further. > > > > Thanks, > > Sudhakar. > > > > From: Aishwarya Sinhasane <aishwaryasinhas...@gmail.com > <mailto:aishwaryasinhas...@gmail.com>> > Reply-To: "dev@airavata.apache.org <mailto:dev@airavata.apache.org>" > <dev@airavata.apache.org <mailto:dev@airavata.apache.org>> > Date: Friday, July 1, 2022 at 12:02 PM > To: "dev@airavata.apache.org <mailto:dev@airavata.apache.org>" > <dev@airavata.apache.org <mailto:dev@airavata.apache.org>> > Subject: Regarding seagrid desktop client molecule viewer inetgration > > > > Hello Sudhakar > > > > I was working on integrating a molecule viewer in seagrid desktop client. I > used the NGL Viewer. I tried various other molecule viewers developed in > javascript but some of them are not working properly so I choose NGLViewer. > This molecule viewer supports mmCIF, PDB, mol2, SDF, MMTF structures. > > > > I am trying to implement a JSMol molecule viewer. Please refer to the > attached screenshots. >
