yasithdev opened a new pull request, #247: URL: https://github.com/apache/airavata-portals/pull/247
Builds on the Keycloak-token-only auth externalization (#245) to make the Django portal a thin, lean layer. Behavior-preserving throughout: `ruff` and `manage.py check` are clean and the portal test suite is unchanged (75 tests; the 2 failures are pre-existing `WithAccess`/`is_owner` proto-gap contract tests, unrelated to this work). ## What changed **Dead-weight removal (several verified passes).** - ~70 MB of orphaned static assets: vendored Bootstrap, the Wagtail-era `media/` tree, doc screenshots. - The desktop/CLI login flow (superseded by browser PKCE), the per-protocol job-submission/data-movement subsystem (7 views + 8 routes + 10 JS services + its contract test, unreachable on both sides), the `Users` JS service, and assorted dead views/branches/params (`format=None` DRF vestige, `_gateway_groups` dead branch, the orphaned `MEDIA` route/settings, etc.). - Dead settings/config: the `messages` framework, `humanize`, `LOGIN_REDIRECT_URL`, `AUTHENTICATION_BACKENDS`, dead context-processor output, the Django-admin compatibility surface (`is_staff`/`has_perm`/`has_module_perms`), `vetur.config.js`, and redundant npm deps (verified to resolve via the linked common-ui). - Dropped the transitively-dead `papermill`/`nbconvert` deps. **Slimmed the custom DRF replacement (`web.py`, 1056 → 777 lines).** Removed the unused serializer machinery, the shadowed ORM `get_object`/`get_queryset`, the permission-composition algebra, `ModelViewSet`/namespaces, and other DRF surface the portal never exercises — verified by MRO introspection that no routed action binds to a removed body, then collapsing the model mixins to abstract markers. **Navbar:** moved the notifications bell from the bottom sidebar utilities to the top brand row (right of the logo/title, icon-only). **Build/CI:** fixed `test_js.sh` (the workspace step had no test script and was short-circuiting the admin vitest run). ## Test plan - `uv run ruff check .` — clean - `uv run python manage.py check` — no issues - `uv run ./runtests.py` — 75 tests, 2 pre-existing failures (unrelated `WithAccess` contract tests) - per-app Vite builds (`common`, `admin`, `groups`, `workspace`) succeed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
