guan404ming commented on code in PR #55291:
URL: https://github.com/apache/airflow/pull/55291#discussion_r2327797697
##########
airflow-core/src/airflow/ui/src/layouts/Details/Gantt/Gantt.tsx:
##########
@@ -185,9 +187,9 @@ export const Gantt = ({ limit }: Props) => {
minBarLength: MIN_BAR_WIDTH,
},
],
- labels: [],
+ labels: chartLabels,
}),
- [data],
+ [data, chartLabels],
Review Comment:
```suggestion
[data, flatNodes],
```
##########
airflow-core/src/airflow/ui/src/layouts/Details/Gantt/Gantt.tsx:
##########
@@ -185,9 +187,9 @@ export const Gantt = ({ limit }: Props) => {
minBarLength: MIN_BAR_WIDTH,
},
],
- labels: [],
+ labels: chartLabels,
Review Comment:
```suggestion
labels: flatNodes.map((node) => node.id),
```
I think it would be better and more clear in this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
