HsiuChuanHsu opened a new pull request, #55403:
URL: https://github.com/apache/airflow/pull/55403
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
## Description
The existing `ssl_ca_cert` setting is only supported within the
`kubernetes_executor` configuration, and its scope does not extend to the
`KubernetesPodOperator`.
https://github.com/apache/airflow/blob/7ef251d0b62ba0abc186061413ee33da3af3d548/providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/kube_client.py#L151-L153
> **Problem**: The current implementation of the KubernetesPodOperator does
not inherit SSL configurations from its parent executor or environment variables
## Solution
The KubernetesPodOperator operates in two primary modes to handle
synchronous and asynchronous tasks:
1. **deferrable=False**
- KubernetesPodOperator -> KubernetesHook -> Kubernetes API
2. **deferrable=True**
- KubernetesPodOperator -> KubernetesPodTrigger -> AsyncKubernetesHook ->
Kubernetes API
**Enhancements**
1. Extend `KubernetesPodOperator` to Support `ssl_ca_cert`
2. Enhance `KubernetesHook` for Proper SSL CA Configuration
3. Define a Clear Inheritance Order
- **KubernetesPodOperator's ssl_ca_cert parameter**
This will be the primary source for the CA certificate path.
```yaml
airflow.cfg
[kubernetes_executor]
ssl_ca_cert = /etc/ssl/certs/ca.crt
```
```python
# The Pod will automatically use [kubernetes_executor] ssl_ca_cert =
/etc/ssl/certs/ca.crt
pod_operator = KubernetesPodOperator(
task_id="my_task",
image="my-image",
# ssl_ca_cert is not specified, so it uses the executor's setting
)
```
- **kubernetes_executor.ssl_ca_cert setting**:
If the `KubernetesPodOperator parameter` is not provided, the system will
automatically fall back to the setting defined in the `kubernetes_executor`
configuration.
```python
# The Pod will use /custom/path/ca.crt, ignoring the executor's setting
pod_operator = KubernetesPodOperator(
task_id="my_task",
image="my-image",
ssl_ca_cert="/custom/path/ca.crt" # Overrides the global setting
)
```
close: #53192
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
