Hello everyone, I am cancelling the vote on AIP-120 [1].
The vote brought very useful feedback on how the new workflow behaves in practice, mostly from Ash, who tried it end to end on a test PR [2], and also from Andrew and Adam. Thank you. I would rather fix what came up first than ask you to vote on a flow we already know needs work. What we will resolve before the new vote: * Fork CI tests the tip of the branch, while project CI tests the PR merged into the target branch. * Adding "use project ci" neither withdraws a green "CI passed" status nor starts project CI, so the PR can still merge on the fork result, including through auto-merge. * A PR is drafted as soon as a failed run is seen, and it can stay in draft for too long afterwards. Ash suggested waiting a day first. * The 7-day window for closing inactive PRs is too short. Ash and Adam proposed 30 days. * When a fork's Actions settings block the workflow, the run ends in "Startup Failure" and the PR shows nothing. The bot comment should also point to the contributor docs rather than the design doc, as Andrew suggested. * Status reaches the PR late and with little detail. * The vote email has to say clearly and up front that some PRs will be merged based on CI results from forks, without a project CI run. It will also answer Ash's questions about the problem this solves and what it means for our trust boundaries. Nothing changes in the meantime: fork CI stays switched off for everyone except the pilot. I will call a new vote once all of this is resolved and tested in the pilot, likely in a couple of days. Votes from this thread do not carry over, so please vote again then. Ash, and everyone else: please keep trying it and tell us how it works. That feedback is what will make it better. To try it, add the "use fork ci" label to your own PR and push. Setup is described in the contributor docs [3]. Feedback from the maintainer side would help most, for example what it takes to merge a PR once fork CI is green, and anything from larger core PRs. Please reply here or in #internal-airflow-ci-cd. J. [1] https://lists.apache.org/thread/hh5p3j9cj66767lj3gpotfz8rgvkt0oh [2] https://github.com/apache/airflow/pull/76536 [3] https://github.com/apache/airflow/blob/main/contributing-docs/18_contribution_workflow.rst#ci-in-your-fork --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
