Hello. Can you review my pull request here: https://github.com/apache/incubator-airflow/pull/2723
I have fixed all bugs I have found during my tests, I would be glad if it is accepted. Thanks a lot. Gaetan Semet On 2017-10-28 10:29, "[email protected]"<[email protected]> wrote: > Hello Airflow community, > > My name is Gaetan Semet, and I have prepared a Pull Request adding easy > support for URL prefix (or "web root") to two typical endpoints of an airflow > infrastructure: > - Pull Request: https://github.com/apache/incubator-airflow/pull/2723 > - Jira Ticket: https://issues.apache.org/jira/browse/AIRFLOW-1755 > > It adds two configuration key in airflow.cfg: > > # Root URL to use for the web server > web_server_url_prefix: /flower > ... > # The root URL for Flower > flower_url_prefix = /flower > > I am aware that this ability was offered to flower using a custom > configuration file (`--flower_conf`), but I also wanted to do it for the > Airflow main UI. > > Now we can have the following scheme on the url in our Kubernetes cluster (of > course, provided good configuration of the frontend reverse proxy): > > http://my.internal-cluster/datascience/airflow > > that would redirect directly to > > http://my.internal-cluster/datascience/airflow/admin > > because, Flask-admin... :) > > And also flower can be available at: > > http://my.internal-cluster/datascience/airflow/flower > > I would be glad if you accept this PR, I got a review from @ashb to adapt > `url_for`, I would be glad to work on it on another issue later on if you > agree. > > By the way, I am also working on Helm support for Kubernetes (see > https://github.com/mumoshu/kube-airflow/pull/16). I predict a very bright > future for Kubernetes and Airflow (thanks to the work of @dimberman!) :D > > Thanks a lot > Gaetan Semet >
