I am going to cancel and start a new vote. Broken S3 hook is not acceptable for a 1.X release, IMO. Hopefully we can get the release out this week.
On Wed, Nov 22, 2017 at 6:05 AM, Bolke de Bruin <[email protected]> wrote: > Thanks for the quick patch. > > I have merged it into 1.9-test and 1.9-stable. I leave it up for Chris to > decide what to do with the release. > > - Bolke > > > On 21 Nov 2017, at 18:24, Ash Berlin-Taylor <ash_airflowlist@firemirror. > com> wrote: > > > > -0.5, from me again (Sorry!) > > > > We got as far as deploying this to our test cluster and ran into another > bug in the S3Hook: `list_keys` doesn't work (and I suspect list_prefixes > will be similarly broken, though we don't use it ourselves): > > > > File "/usr/local/lib/python3.5/site-packages/airflow/hooks/S3_hook.py", > line 104, in list_keys > > return [k.Key for k in response['Contents']] if > response.get('Contents') else None > > File "/usr/local/lib/python3.5/site-packages/airflow/hooks/S3_hook.py", > line 104, in <listcomp> > > return [k.Key for k in response['Contents']] if > response.get('Contents') else None > > AttributeError: 'dict' object has no attribute 'Key' > > > > Reported as https://issues.apache.org/jira/browse/AIRFLOW-1839 > > > >> On 18 Nov 2017, at 17:36, Chris Riccomini <[email protected]> > wrote: > >> > >> Hey all, > >> > >> I have cut Airflow 1.9.0 RC3. This email is calling a vote on the > release, > >> which will last for 72 hours. Consider this my (binding) +1. > >> > >> Airflow 1.9.0 RC3 is available at: > >> > >> *https://dist.apache.org/repos/dist/dev/incubator/airflow/1.9.0rc3/ > >> <https://dist.apache.org/repos/dist/dev/incubator/airflow/1.9.0rc3/>* > >> > >> apache-airflow-1.9.0rc3+incubating-source.tar.gz is a source release > that > >> comes with INSTALL instructions. > >> apache-airflow-1.9.0rc3+incubating-bin.tar.gz is the binary Python > "sdist" > >> release. > >> > >> Public keys are available at: > >> > >> https://dist.apache.org/repos/dist/release/incubator/airflow/ > >> > >> The release contains the following JIRAs: > >> > >> https://issues.apache.org/jira/browse/AIRFLOW-1795 > >> > >> Along with all JIRAs that were in 1.9.0RC2 (see previous VOTE email for > >> full list). > >> > >> Cheers, > >> Chris > > > >
