I think we need some more eyes on the PR. As of now, it got stuck between Bolke and me :).
I am not able to convince Bolke, that to pre-generate all links on UI is a time & cpu consuming task, as web server has to prepare all such links before handing the rendering work to UI. While he is not able to convince me that UI processes 1 task node at a time, so there would be no extra load on the web server. On Thu, Nov 23, 2017 at 7:12 PM, Sumit Maheshwari <[email protected]> wrote: > Ping! > > folks, please review :) > > > On Mon, Nov 6, 2017 at 12:55 PM, Driesprong, Fokko <[email protected]> > wrote: > >> Hi Sumit, >> >> Thanks for the PR. I think this is a nice addition. This would also be >> applicable for the Google Cloud and Databricks operators. >> >> I've had two remarks on the code. I still have to fire up Airflow to see >> how this would work in the UI. >> >> Cheers, Fokko >> >> 2017-11-06 8:07 GMT+01:00 Sumit Maheshwari <[email protected]>: >> >> > Hi All, >> > >> > As of now TI model view in Airflow is very static and each operator has >> to >> > make use of given options only. I have opened a PR to add support for >> more >> > links (buttons) on model view, which can redirect users to the outside >> of >> > Airflow programmatically. >> > >> > Some simple use cases of this feature could be: >> > - Redirecting users to Hadoop RM page >> > - Adding quick links to operators documentation >> > - Better integration with third-party operators >> > >> > Please review following PR ( >> > https://github.com/apache/incubator-airflow/pull/2657) and give your >> > thoughts, +1s or -1s. >> > >> > >> > Thanks, >> > Sumit >> > >> > >
